Page MenuHomePhabricator
Differential D14053

[native] DisplayCommunityDirectoryPrompt
DraftPublic
Actions

Authored by varun on Tue, Nov 26, 10:14 PM.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
ashoat
Summary

holding this as a draft until i add a check that user is on home screen and there are no overlays present

Depends on D13997

Test Plan

tbd

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Tue, Nov 26, 10:14 PM
varun held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptTue, Nov 26, 10:14 PM
varun added a child revision: D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.Tue, Nov 26, 10:19 PM
varun added inline comments.Tue, Nov 26, 10:20 PM
native/components/display-community-directory-prompt.react.js
53

an undefined fid means the user hasn't been prompted to set a farcaster association yet

varun added inline comments.Tue, Nov 26, 10:26 PM
native/components/display-community-directory-prompt.react.js
66

as @ashoat noted on a previous diff in this stack, this isn't a promise, but rather a function that returns a promise. i should revise this before publishing to avoid calling the keyserver endpoint multiple times

Harbormaster completed remote builds in B32879: Diff 46094.Tue, Nov 26, 10:32 PM

Revision Contents
Changeset List

PathSize
native/
components/
87 lines
2 lines

Diff 46094

View Options

native/components/display-community-directory-prompt.react.js

Loading...
View Options

native/root.react.js

Loading...