Page MenuHomePhabricator

[native] button in community drawer for exploring communities
AcceptedPublic

Authored by varun on Nov 21 2024, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 6, 1:20 AM
Unknown Object (File)
Mon, Dec 30, 10:32 PM
Unknown Object (File)
Sat, Dec 28, 7:27 AM
Unknown Object (File)
Thu, Dec 26, 7:12 PM
Unknown Object (File)
Thu, Dec 26, 7:12 PM
Unknown Object (File)
Thu, Dec 26, 11:38 AM
Unknown Object (File)
Sat, Dec 21, 8:27 PM
Unknown Object (File)
Sat, Dec 21, 8:27 PM
Subscribers

Details

Reviewers
ashoat
Summary

https://linear.app/comm/issue/ENG-9850/add-new-button-in-profile-section-on-native-that-navigates-to

We need this button so that users can navigate back to the directory after it's been dismissed

Depends on D13986

Test Plan

button is pressable, but currently does nothing. in a subsequent diff we will navigate to the community directory from here onPress

Simulator Screenshot - iPhone 16 Pro Max - 2024-11-21 at 03.13.14.png (2×1 px, 163 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

native/navigation/community-drawer-content.react.js
173

we can remove this once the button does something

ashoat added inline comments.
native/navigation/community-drawer-content.react.js
173

Seems like you're going to be gating your handler component (that shows the modal) somehow... would it make sense to have a gate variable, so both checks are associated and can be flipped at once?

188–189

Not sure these two lines are necessary

This revision is now accepted and ready to land.Nov 21 2024, 4:04 PM