Paths

Table of Contentst

-
keyserver/src/fetchers/
-
src/
-
fetchers/
-
community-fetchers.js
-
thread-permission-fetchers.js

Differential D14181

[keyserver] filter out communities that viewer is a member of or that aren't public
ClosedPublic
Actions

Authored by varun on Dec 23 2024, 7:56 AM.

Details

Reviewers

ashoat

Commits

rCOMM7f2d97318b52: [keyserver] filter out communities that viewer is a member of or that aren't…

Summary

We don't want to leak private groups via this endpoint

Public = has a Farcaster channel tag association

https://linear.app/comm/issue/ENG-10023/only-return-communities-from-fetchallcommunityinfoswithnames-if-member

Depends on D14054

Test Plan

opened the directory and confirmed that only public communities of which i wasn't a member were displayed

joined some communities, closed the community drawer and then reopened drawer and directory; confirmed that the communities i had just joined were no longer visible in the directory

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Dec 23 2024, 7:56 AM

varun held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptDec 23 2024, 7:56 AM

varun edited the summary of this revision. (Show Details)Dec 23 2024, 7:56 AM

ashoat added inline comments.Dec 23 2024, 8:08 AM

keyserver/src/fetchers/community-fetchers.js
107–109 ↗	(On Diff #46598)	Let's make this change as discussed in 1:1

Harbormaster completed remote builds in B33192: Diff 46598.Dec 23 2024, 8:14 AM

ashoat added inline comments.Dec 23 2024, 8:24 AM

keyserver/src/fetchers/community-fetchers.js
97 ↗	(On Diff #46598)	Can you find a better name for this?
99 ↗	(On Diff #46598)	Instead of one query per community, let's have a single query that checks all of them. We can do this by calling `checkThreads`, or introducing a new helper that is similar to `viewerIsMember`, but can handle checking multiple communities at once in a single query (and calls `checkThreads` under the hood)

revise and publish

varun published this revision for review.Dec 23 2024, 9:17 PM

varun retitled this revision from [keyserver] filter out communities that viewer is not a member of and that aren't public to [keyserver] filter out communities that viewer is a member of or that aren't public.

varun edited the test plan for this revision. (Show Details)

varun edited the summary of this revision. (Show Details)

varun added a parent revision: D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.

Harbormaster completed remote builds in B33193: Diff 46599.Dec 23 2024, 9:32 PM

ashoat accepted this revision.Dec 24 2024, 10:18 AM

ashoat added inline comments.

keyserver/src/fetchers/community-fetchers.js
85 ↗	(On Diff #46599)	Can we rename this to `fetchTaggedNonMemberCommunityInfosWithNames`?
97 ↗	(On Diff #46599)	Can we move the filter for `!!row.farcasterChannelID` here, so we don't query for membership info on non-tagged communities?

This revision is now accepted and ready to land.Dec 24 2024, 10:18 AM

return communities that the member is a part of

ashoat accepted this revision.Jan 7 2025, 3:38 PM

ashoat added inline comments.

keyserver/src/fetchers/community-fetchers.js
85 ↗	(On Diff #46606)	Let's rename to `fetchCommunityInfosForNativeDrawer`

Harbormaster completed remote builds in B33198: Diff 46606.Jan 7 2025, 3:56 PM

varun added inline comments.Jan 14 2025, 12:45 PM

keyserver/src/fetchers/community-fetchers.js
85 ↗	(On Diff #46606)	https://linear.app/comm/issue/ENG-9835/rename-fetchallcommunityinfoswithnames-to-something-else-to-reflect

varun added a child revision: D14204: [native] fix avatars in directory.Jan 14 2025, 2:36 PM

Closed by commit rCOMM7f2d97318b52: [keyserver] filter out communities that viewer is a member of or that aren't… (authored by varun). · Explain WhyMar 1 2025, 2:25 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM7f2d97318b52: [keyserver] filter out communities that viewer is a member of or that aren't….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

community-fetchers.js

20 lines

thread-permission-fetchers.js

14 lines

Diff 47320

View Options

keyserver/src/fetchers/community-fetchers.js

// @flow		// @flow

import { type BaseStoreOpsHandlers } from './base-ops.js';		import { type BaseStoreOpsHandlers } from './base-ops.js';
import type { RawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';		import type { RawThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import type {		import type {
ClientDBThreadInfo,		ClientDBThreadInfo,
MinimallyEncodedRawThreadInfos,		RawThreadInfos,
ThreadStore,		ThreadStore,
} from '../types/thread-types.js';		} from '../types/thread-types.js';
import {		import {
convertClientDBThreadInfoToRawThreadInfo,		convertClientDBThreadInfoToRawThreadInfo,
convertRawThreadInfoToClientDBThreadInfo,		convertRawThreadInfoToClientDBThreadInfo,
} from '../utils/thread-ops-utils.js';		} from '../utils/thread-ops-utils.js';

export type RemoveThreadOperation = {		export type RemoveThreadOperation = {
Show All 24 Lines	export type ClientDBThreadStoreOperation =
\| RemoveThreadOperation		\| RemoveThreadOperation
\| RemoveAllThreadsOperation		\| RemoveAllThreadsOperation
\| ClientDBReplaceThreadOperation;		\| ClientDBReplaceThreadOperation;

export const threadStoreOpsHandlers: BaseStoreOpsHandlers<		export const threadStoreOpsHandlers: BaseStoreOpsHandlers<
ThreadStore,		ThreadStore,
ThreadStoreOperation,		ThreadStoreOperation,
ClientDBThreadStoreOperation,		ClientDBThreadStoreOperation,
MinimallyEncodedRawThreadInfos,		RawThreadInfos,
ClientDBThreadInfo,		ClientDBThreadInfo,
> = {		> = {
processStoreOperations(		processStoreOperations(
store: ThreadStore,		store: ThreadStore,
ops: $ReadOnlyArray<ThreadStoreOperation>,		ops: $ReadOnlyArray<ThreadStoreOperation>,
): ThreadStore {		): ThreadStore {
if (ops.length === 0) {		if (ops.length === 0) {
return store;		return store;
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines