If the user opened the modal by accepting the bottom sheet prompt, we'll still want to show them the nux tip when they close the modal so that they can find it in the future.
Depends on D14420
Details
Details
when i open the modal from the community drawer and then close it, nothing happens.
but if i open the modal from the bottom sheet and then close it, i see the NUX tip indicating where to find the directory
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Passing back to you with a question about why we avoid goBack when showing the NUX tip
| native/components/community-joiner-modal.react.js | ||
|---|---|---|
| 202 ↗ | (On Diff #47298) | Should we extract navigate and goBack like we do in D14420? |
| 207 ↗ | (On Diff #47298) | I'm confused why we don't goBack before showing the NUX tip. Is it because the NUX tip replaces the CommunityJoinerModal? If that's the case, how come it doesn't apply to D14420, where we call goBack before navigate? |
| native/components/community-joiner-modal.react.js | ||
|---|---|---|
| 207 ↗ | (On Diff #47298) | Okay, got it |