Paths

Table of Contentst

Differential D13995

[native] introduce community list component
Needs RevisionPublic
Actions

Authored by varun on Thu, Nov 21, 1:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 9:05 PM

	Unknown Object (File)
	Thu, Nov 21, 9:05 PM

	Unknown Object (File)
	Thu, Nov 21, 9:05 PM

	F3336053: RPReplay_Final1732225392.MP4
	Thu, Nov 21, 1:44 PM

Subscribers

Details

Reviewers

Summary

this component is basically a fork of the native ThreadList component

the differences are, the new component:

renders CommunityListItems
does not have an onSelect (we may consider adding this in the future to display community info)
does not have a searchRef (we don't want to call focus() on the textInput, keyboard should not display unless user presses search bar)

Depends on D13994

Test Plan

see video

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Thu, Nov 21, 1:41 PM

Herald added a subscriber: tomek. · View Herald TranscriptThu, Nov 21, 1:41 PM

varun edited the test plan for this revision. (Show Details)Thu, Nov 21, 1:44 PM

varun attached a referenced file: F3336053: RPReplay_Final1732225392.MP4. (Show Details)

varun mentioned this in D13994: [native] community list item component.

Harbormaster completed remote builds in B32756: Diff 45932.Thu, Nov 21, 2:00 PM

varun requested review of this revision.Thu, Nov 21, 2:00 PM

React class components should not be used for new components in 95% of cases... can you try to make this a function component?

native/components/community-list.react.js
44	We should not be introducing any new class components
50–65	This messy pattern is approximating `React.useMemo`
84	There's a shorthand for this now
95

This revision now requires changes to proceed.Thu, Nov 21, 6:28 PM

varun added a child revision: D13996: [native] community joiner modal.Thu, Nov 21, 7:58 PM

Revision Contents
Changeset List

Path

Size

native/

components/

community-list.react.js

145 lines

Diff 45932

native/components/community-list.react.js

Loading...