You're right. I wrote a script here that I'll need you to run to get the IDs

D14145

This should say IDs instead of names, but the comment will be removed entirely when I populate the list

the keyserver should never return a community with a missing threadInfo, but it's technically possible. (we call fetchPrivilegedThreadInfos on the keyserver to get the threadInfos, and this function could return an empty array.) we can just omit the communities that are missing a threadInfo and maybe add a log on the keyserver to point out the unexpected state

passing initialLayout can improve the initial rendering performance. you're right that this should be at the top level since it's static

I git grep'd for these types in the flow-typed subdirectory. but now that i look more closely, these are both any-typed in native/flow-typed/npm/react-native-gesture-handler_v2.x.x.js...

declare export type AnimatedValue = any;
declare export type ViewStyle = any;

Maybe better to copy-paste the "Vaguely copied" lines definitions in native/flow-typed/npm/@react-navigation/core_v6.x.x.js

Let's calculate this based on our styles. First we factor them out:

// @flow

export const modalBorderWidth = 2;

export const modalMarginHorizontal = 15;

export const modalPadding = 12;

Then we update native/components/modal.react.js to use those.

And finally we calculate this initialLayout width based on useWindowDimensions().width - 2 * (sum of above)

creating a new file called lib/facts/communities.js for these IDs

decided to leave the keyserver API as-is for now

i think we should pair on this

https://phab.comm.dev/D13996?id=46372#inline-79685 I left a comment here, but I think we should pair on this. I can create a follow-up task to unblock this for now, since you're probably busy this weekend. I was copying and pasting a lot from that file, which feels wrong...

I think you should just copy-paste from the file. Can you try updating the diff with copy-paste, and then we can discuss from there?

diff --git a/native/components/community-joiner-modal.react.js b/native/components/community-joiner-modal.react.js
index 6ea7820d70..e739f631f0 100644
--- a/native/components/community-joiner-modal.react.js
+++ b/native/components/community-joiner-modal.react.js
@@ -42,7 +42,7 @@ const routes = [
 
 function CommunityJoinerModal(props: Props): React.Node {
   const { params } = props.route;
-  const communities = params?.communities;
+  const { communities } = params;
 
   const viewerID = useSelector(
     state => state.currentUserInfo && state.currentUserInfo.id,

at some point i think flow was complaining about this line so i added the fallback but i must be misremembering. however, flow is happy with the above change so i'll remove the ?.

doesn't appear to be used anywhere, removing

we're using modalBackground there. I'm going to use modalBackground here as well instead of tabBarBackground

it's not, thanks for catching

getting two flow errors:

varun@varuns-MacBook-Pro native % flow
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ navigation/chat-tab-bar-button.react.js:82:19

Cannot create TabBarItem element because inexact InterpolationConfigType [1] is incompatible with exact
InterpolationConfigType [2] in the first parameter of property position.interpolate. [incompatible-exact]

     navigation/chat-tab-bar-button.react.js
      79│
      80│     return (
      81│       <TabBarItem
      82│         position={position.current}
      83│         route={route}
      84│         navigationState={dummyNavigationState}
      85│         onPress={dummyCallback}

     flow-typed/npm/react-native-tab-view_v3.x.x.js
 [2]  39│     interpolate(config: InterpolationConfigType): AnimatedInterpolation;

     ../node_modules/react-native/Libraries/Animated/nodes/AnimatedValue.js
 [1] 230│     config: InterpolationConfigType<OutputT>,


Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ navigation/chat-tab-bar-button.react.js:82:19

Cannot create TabBarItem element because inexact InterpolationConfigType [1] is incompatible with exact
InterpolationConfigType [2] in the first parameter of property interpolate of the return value of property
position.interpolate. [incompatible-exact]

     navigation/chat-tab-bar-button.react.js
      79│
      80│     return (
      81│       <TabBarItem
      82│         position={position.current}
      83│         route={route}
      84│         navigationState={dummyNavigationState}
      85│         onPress={dummyCallback}

     flow-typed/npm/react-native-tab-view_v3.x.x.js
 [2]  39│     interpolate(config: InterpolationConfigType): AnimatedInterpolation;

     ../node_modules/react-native/Libraries/Animated/nodes/AnimatedInterpolation.js
 [1] 336│     config: InterpolationConfigType<NewOutputT>,



Found 2 errors

not sure how to resolve these

Can this be replaced with ...tabProps?

We can just replace these four lines with tabProps

Thanks for trying. Let's bring back your original approach, where you imported the any-types from react-native-gesture-handler/@react-native

On first glance, this seemed like it was solving an extremely serious issue... the kind that should've been fixed in a separate diff, with an Urgent issue so we could prioritize shipping a fix.

Because of how serious it seemed, I opted to spend some time analyzing the code. Turns out it's not actually used in our case, so there is no urgent issue to solve. But I wish that the same "alarm bells" had been ringing in your head, and that you had spent some time analyzing the issue, and explaining why it didn't need an immediate fix...