Page MenuHomePhabricator
Differential D13986

[native] bottom sheet for exploring communities
Needs ReviewPublic
Actions

Authored by varun on Wed, Nov 20, 11:50 PM.
Tags
None
Referenced Files
F3332704: D13986.id45917.diff
Thu, Nov 21, 1:14 AM
F3332689: D13986.id.diff
Thu, Nov 21, 1:14 AM
F3332686: D13986.diff
Thu, Nov 21, 1:14 AM
F3332425: Simulator Screenshot - iPhone 16 Pro Max - 2024-11-21 at 02.40.15.png
Wed, Nov 20, 11:56 PM
Subscribers
tomek

Details

Reviewers
ashoat
Summary

in a subsequent diff, the buttons in this bottom sheet will lead to different navigations

Test Plan

successfully navigated to and dismissed bottom sheet on android and ios. confirmed that the buttons were positioned correctly on multiple screen sizes

Simulator Screenshot - iPhone 16 Pro Max - 2024-11-21 at 02.40.15.png (2×1 px, 248 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Wed, Nov 20, 11:50 PM
Herald added a subscriber: tomek. · View Herald TranscriptWed, Nov 20, 11:50 PM
varun added inline comments.Wed, Nov 20, 11:55 PM
native/components/directory-prompt-bottom-sheet.react.js
41

we add buttonHeight twice here since there are two buttons

47–53

this will be replaced with navigations in a subsequent diff

native/components/directory-prompt.react.js
10

Maybe something like this would be better. "Explore communities" would be redundant with our button text, though

varun edited the test plan for this revision. (Show Details)Wed, Nov 20, 11:56 PM
varun attached a referenced file: F3332425: Simulator Screenshot - iPhone 16 Pro Max - 2024-11-21 at 02.40.15.png. (Show Details)
Harbormaster completed remote builds in B32742: Diff 45917.Thu, Nov 21, 12:08 AM
varun requested review of this revision.Thu, Nov 21, 12:08 AM
varun added a child revision: D13987: [native] button in community drawer for exploring communities.Thu, Nov 21, 12:15 AM

Revision Contents
Changeset List

PathSize
native/
components/
97 lines
58 lines
navigation/
7 lines
2 lines
vectors/
63 lines

Diff 45917

View Options

native/components/directory-prompt-bottom-sheet.react.js

Loading...
View Options

native/components/directory-prompt.react.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...
View Options

native/vectors/community-logo.react.js

Loading...