in a subsequent diff, the buttons in this bottom sheet will lead to different navigations
Details
- Reviewers
ashoat
successfully navigated to and dismissed bottom sheet on android and ios. confirmed that the buttons were positioned correctly on multiple screen sizes
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/components/directory-prompt-bottom-sheet.react.js | ||
---|---|---|
41 ↗ | (On Diff #45917) | we add buttonHeight twice here since there are two buttons |
47–53 ↗ | (On Diff #45917) | this will be replaced with navigations in a subsequent diff |
native/components/directory-prompt.react.js | ||
10 ↗ | (On Diff #45917) | Maybe something like this would be better. "Explore communities" would be redundant with our button text, though |
Code is great, but I want to workshop the design & copy just a little bit
native/components/directory-prompt.react.js | ||
---|---|---|
10 ↗ | (On Diff #45917) | How about "Discover communities" |
11–13 ↗ | (On Diff #45917) | This text feels weird and superfluous... I feel like it's not really communicating anything. How about:
"Interest-based" sounds corpo, but maybe something like that? |
native/vectors/community-logo.react.js | ||
6 ↗ | (On Diff #45917) | Where'd you get this SVG? What's the license? Why not use one of the icons? I'm not sure I love the cutout that the foreground silhouette makes against the background silhouettes |
9 ↗ | (On Diff #45917) | Thinking more about this SVG graphic, I think it could be cool to have one if we do something more with it than an icon. I wonder if we could use the graphic to preview some communities that people on the app might want to join... eg. Geopolitics, Screens, NYC, etc. Maybe worth checking with Rahul about? |
native/components/directory-prompt.react.js | ||
---|---|---|
11–13 ↗ | (On Diff #45917) |
Any of these work? |
native/vectors/community-logo.react.js | ||
9 ↗ | (On Diff #45917) |
native/components/directory-prompt.react.js | ||
---|---|---|
11–13 ↗ | (On Diff #45917) | Hmm, I don't love the trailing prepositional phrase there... can you rephrase in a way that avoids it? |
native/components/directory-prompt.react.js | ||
---|---|---|
11–13 ↗ | (On Diff #45917) | Do you not like the prepositional phrase or do you not like that it's at the end? Would this work?
|
native/components/directory-prompt.react.js | ||
---|---|---|
11–13 ↗ | (On Diff #45917) | It's definitely better in the middle, but still sounds awkward to me |
I imported the SVG into Figma and flattened it. The SVG to React Native SVG converter that I use (I think this is the one recommended by Expo) was able to handle the flattened SVG much better