[native] bottom sheet for exploring communities
Needs RevisionPublic
Actions

Authored by varun on Wed, Nov 20, 11:50 PM.

Details

Reviewers

Summary

in a subsequent diff, the buttons in this bottom sheet will lead to different navigations

Test Plan

successfully navigated to and dismissed bottom sheet on android and ios. confirmed that the buttons were positioned correctly on multiple screen sizes

Simulator Screenshot - iPhone 16 Pro Max - 2024-11-21 at 02.40.15.png (2×1 px, 248 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Wed, Nov 20, 11:50 PM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Nov 20, 11:50 PM

varun added inline comments.Wed, Nov 20, 11:55 PM

native/components/directory-prompt-bottom-sheet.react.js
41	we add buttonHeight twice here since there are two buttons
47–53	this will be replaced with navigations in a subsequent diff
native/components/directory-prompt.react.js
10	Maybe something like this would be better. "Explore communities" would be redundant with our button text, though

varun edited the test plan for this revision. (Show Details)Wed, Nov 20, 11:56 PM

varun attached a referenced file: F3332425: Simulator Screenshot - iPhone 16 Pro Max - 2024-11-21 at 02.40.15.png. (Show Details)

Harbormaster completed remote builds in B32742: Diff 45917.Thu, Nov 21, 12:08 AM

varun requested review of this revision.Thu, Nov 21, 12:08 AM

varun added a child revision: D13987: [native] button in community drawer for exploring communities.Thu, Nov 21, 12:15 AM

varun added inline comments.Thu, Nov 21, 7:31 AM

native/components/directory-prompt.react.js
7	This comment should be removed
native/vectors/community-logo.react.js
6	Logo doesn’t really make sense here. Will change this to CommunityIcon

Code is great, but I want to workshop the design & copy just a little bit

native/components/directory-prompt.react.js
10	How about "Discover communities"
11–13	This text feels weird and superfluous... I feel like it's not really communicating anything. How about: Want to join some interest-based communities on Comm? "Interest-based" sounds corpo, but maybe something like that?
native/vectors/community-logo.react.js
6	Where'd you get this SVG? What's the license? Why not use one of the icons? I'm not sure I love the cutout that the foreground silhouette makes against the background silhouettes
9	Thinking more about this SVG graphic, I think it could be cool to have one if we do something more with it than an icon. I wonder if we could use the graphic to preview some communities that people on the app might want to join... eg. Geopolitics, Screens, NYC, etc. Maybe worth checking with Rahul about?