native/navigation/community-drawer-content.react.js
173	Seems like you're going to be gating your handler component (that shows the modal) somehow... would it make sense to have a gate variable, so both checks are associated and can be flipped at once?
188–189	Not sure these two lines are necessary

This revision is now accepted and ready to land.Nov 21 2024, 4:04 PM

varun mentioned this in D13996: [native] community joiner modal.Nov 21 2024, 7:58 PM

Closed by commit rCOMMc014a2f291b8: [native] button in community drawer for exploring communities (authored by varun). · Explain WhyJan 14 2025, 12:55 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMc014a2f291b8: [native] button in community drawer for exploring communities.

ashoat added inline comments.Jan 14 2025, 2:50 PM

native/navigation/root-navigator.react.js
85 ↗	(On Diff #46680)	This is a bad place to put this, and we should never have `export const` variables in most files, especially a file like this one

varun mentioned this in rCOMM8d9060f37976: [native] community joiner modal.Feb 11 2025, 6:44 PM

varun mentioned this in rCOMMe4bd51bfcd4a: [native] community joiner modal.Feb 11 2025, 7:43 PM

Revision Contents
Changeset List

Path

Size

native/

navigation/

community-drawer-content.react.js

47 lines

Diff 45918

View Options

native/navigation/community-drawer-content.react.js

Show First 20 Lines • Show All 573 Lines • ▼ Show 20 Lines	async keyserverAuthInfo => {

const responses: { +[string]: ClientLogInResponse } =		const responses: { +[string]: ClientLogInResponse } =
await callKeyserverEndpoint(		await callKeyserverEndpoint(
'keyserver_auth',		'keyserver_auth',
requests,		requests,
keyserverAuthCallSingleKeyserverEndpointOptions,		keyserverAuthCallSingleKeyserverEndpointOptions,
);		);

const userInfosArrays = [];

let threadInfos: RawThreadInfos = {};		let threadInfos: RawThreadInfos = {};
const calendarResult: WritableCalendarResult = {		const calendarResult: WritableCalendarResult = {
calendarQuery: keyserverAuthInfo.calendarQuery,		calendarQuery: keyserverAuthInfo.calendarQuery,
rawEntryInfos: [],		rawEntryInfos: [],
};		};
const messagesResult: WritableGenericMessagesResult = {		const messagesResult: WritableGenericMessagesResult = {
messageInfos: [],		messageInfos: [],
truncationStatus: {},		truncationStatus: {},
Show All 21 Lines	for (const keyserverID in responses) {
messagesResult.currentAsOf = {		messagesResult.currentAsOf = {
...messagesResult.currentAsOf,		...messagesResult.currentAsOf,
[keyserverID]: responses[keyserverID].serverTime,		[keyserverID]: responses[keyserverID].serverTime,
};		};
updatesCurrentAsOf = {		updatesCurrentAsOf = {
...updatesCurrentAsOf,		...updatesCurrentAsOf,
[keyserverID]: responses[keyserverID].serverTime,		[keyserverID]: responses[keyserverID].serverTime,
};		};
userInfosArrays.push(responses[keyserverID].userInfos);
userInfosArrays.push(responses[keyserverID].cookieChange.userInfos);
}		}

		const userInfosArrays = [
		responses[authoritativeKeyserverID()].userInfos,
		responses[authoritativeKeyserverID()].cookieChange.userInfos,
		tomekUnsubmitted Not Done Inline Actions I don't think it is guaranteed that there will always be a response from the authoritative keyserver, e.g. when adding a new keyserver. We probably should add a condition here and extend a test plan to verify a non-auth keyserver auth. tomek: I don't think it is guaranteed that there will always be a response from the authoritative…
		];

const userInfos = mergeUserInfos(...userInfosArrays);		const userInfos = mergeUserInfos(...userInfosArrays);

return {		return {
threadInfos,		threadInfos,
currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,		currentUserInfo: responses[authoritativeKeyserverID()]?.currentUserInfo,
calendarResult,		calendarResult,
messagesResult,		messagesResult,
userInfos,		userInfos,
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines

[native] button in community drawer for exploring communitiesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45918

native/navigation/community-drawer-content.react.js

[native] button in community drawer for exploring communities
ClosedPublic
Actions

Revision Contents
Changeset List