Page MenuHomePhabricator
Differential D12620

[native] modify SecondaryDeviceQRCodeScanner to support emulator
Needs ReviewPublic
Actions

Authored by varun on Fri, Jun 28, 12:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 6:25 PM
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:45 AM
Subscribers
tomek

Details

Reviewers
ashoat
bartek
Summary

if we're trying to add a device from an iOS simulator or android emulator, we should just display a TextInput where the user can paste the QR Code URL

Depends on D12619

Test Plan

if device is added successfully, we are navigated back upon acknowledging the alert

if device can't be added successfully, we are navigated back when the alert fires

adding keyserver as secondary device works -- appears in DDB correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 41821

View Options

native/profile/linked-devices-header-right-button.react.js

Loading...
View Options

native/profile/profile.react.js

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...
View Options

native/utils/alert-messages.js

Loading...