Page MenuHomePhabricator

[native_rust_library] fix serialization of BackupKeysResult
ClosedPublic

Authored by varun on Fri, May 24, 9:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 9:16 AM
Unknown Object (File)
Wed, Jun 12, 6:50 PM
Unknown Object (File)
Tue, Jun 11, 10:05 AM
Unknown Object (File)
Tue, Jun 11, 10:05 AM
Unknown Object (File)
Tue, Jun 11, 10:05 AM
Unknown Object (File)
Thu, Jun 6, 2:20 PM
Unknown Object (File)
Wed, Jun 5, 10:17 PM
Unknown Object (File)
Wed, Jun 5, 8:18 PM

Details

Summary

the validator in secondary-device-qr-code-scanner-react.js expects the field names to be camelCase

Depends on D12211

Test Plan
const backupKeys = assertWithValidator<BackupKeys>(
  JSON.parse(backupKeysResponse),
  backupKeysValidator,
);

this assertion in secondary-device-qr-code-scanner-react.js was failing, but now succeeds

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Fri, May 24, 9:15 AM

The only changes here after the rebase are code comments – did you accidentally commit the actual code changes separately?

bartek added a subscriber: marcin.

The only changes here after the rebase are code comments – did you accidentally commit the actual code changes separately?

This was fixed by @marcin in D12035. @varun might have been on an outdated master.

Regardless, these comments are good to have.

This revision is now accepted and ready to land.Sun, May 26, 1:39 AM