[keyserver] refactor identity.js
ClosedPublic
Actions

Authored by varun on May 24 2024, 8:57 AM.

Details

Reviewers

ashoat
inka

Commits

rCOMMe41b3f34ec5d: [keyserver] refactor identity.js

Summary

initially i was going to store the primary device ID in the metadata table, but i realized soon after that this wasn't necessary. nonetheless, i thought this change could be useful if we decide to add more rows to the metadata table in the future.

Depends on D12161

Test Plan

successfully updated and fetched identity info from mariadb by calling these functions from keyserver.js

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.May 24 2024, 8:57 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 24 2024, 8:57 AM

varun added a child revision: D12212: [native_rust_library] fix serialization of BackupKeysResult.May 24 2024, 9:00 AM

Harbormaster completed remote builds in B29241: Diff 40641.May 24 2024, 9:16 AM

varun requested review of this revision.May 24 2024, 9:16 AM

rebase

Harbormaster completed remote builds in B29244: Diff 40650.May 24 2024, 9:52 AM

ashoat accepted this revision.May 25 2024, 7:31 AM

ashoat added inline comments.

keyserver/src/user/identity.js
12 ↗	(On Diff #40650)	We only ever capitalize the first letter of `camelCase` variables for React components
106–108 ↗	(On Diff #40650)	Personally I find it more readable to avoid the append