Page MenuHomePhabricator

[keyserver] refactor identity.js
ClosedPublic

Authored by varun on Fri, May 24, 8:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 6:06 PM
Unknown Object (File)
Wed, Jun 12, 5:08 PM
Unknown Object (File)
Tue, Jun 11, 10:05 AM
Unknown Object (File)
Tue, Jun 11, 10:05 AM
Unknown Object (File)
Tue, Jun 11, 10:05 AM
Unknown Object (File)
Sun, Jun 9, 9:16 PM
Unknown Object (File)
Sat, Jun 8, 12:09 PM
Unknown Object (File)
Fri, Jun 7, 7:25 PM
Subscribers

Details

Summary

initially i was going to store the primary device ID in the metadata table, but i realized soon after that this wasn't necessary. nonetheless, i thought this change could be useful if we decide to add more rows to the metadata table in the future.

Depends on D12161

Test Plan

successfully updated and fetched identity info from mariadb by calling these functions from keyserver.js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Fri, May 24, 9:16 AM
ashoat added inline comments.
keyserver/src/user/identity.js
12 ↗(On Diff #40650)

We only ever capitalize the first letter of camelCase variables for React components

106–108 ↗(On Diff #40650)

Personally I find it more readable to avoid the append

This revision is now accepted and ready to land.Sat, May 25, 7:31 AM
This revision was automatically updated to reflect the committed changes.