Page MenuHomePhabricator
Differential D12211

[keyserver] refactor identity.js
ClosedPublic
Actions

Authored by varun on May 24 2024, 8:57 AM.
Tags
None
Referenced Files
F3526849: D12211.id40734.diff
Tue, Dec 24, 1:47 AM
F3526848: D12211.id40641.diff
Tue, Dec 24, 1:47 AM
F3526847: D12211.id40650.diff
Tue, Dec 24, 1:47 AM
F3526835: D12211.id.diff
Tue, Dec 24, 1:47 AM
F3526823: D12211.diff
Tue, Dec 24, 1:46 AM
Unknown Object (File)
Thu, Dec 12, 1:10 PM
Unknown Object (File)
Thu, Dec 5, 11:39 PM
Unknown Object (File)
Fri, Nov 29, 5:13 PM
View All 69 Files
Subscribers
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMMe41b3f34ec5d: [keyserver] refactor identity.js
Summary

initially i was going to store the primary device ID in the metadata table, but i realized soon after that this wasn't necessary. nonetheless, i thought this change could be useful if we decide to add more rows to the metadata table in the future.

Depends on D12161

Test Plan

successfully updated and fetched identity info from mariadb by calling these functions from keyserver.js

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.May 24 2024, 8:57 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 24 2024, 8:57 AM
varun added a child revision: D12212: [native_rust_library] fix serialization of BackupKeysResult.May 24 2024, 9:00 AM
Harbormaster completed remote builds in B29241: Diff 40641.May 24 2024, 9:16 AM
varun requested review of this revision.May 24 2024, 9:16 AM
varun updated this revision to Diff 40650.May 24 2024, 9:35 AM

rebase

Harbormaster completed remote builds in B29244: Diff 40650.May 24 2024, 9:52 AM
ashoat accepted this revision.May 25 2024, 7:31 AM
ashoat added inline comments.
keyserver/src/user/identity.js
12 ↗(On Diff #40650)

We only ever capitalize the first letter of camelCase variables for React components

106–108 ↗(On Diff #40650)

Personally I find it more readable to avoid the append

This revision is now accepted and ready to land.May 25 2024, 7:31 AM
Closed by commit rCOMMe41b3f34ec5d: [keyserver] refactor identity.js (authored by varun). · Explain WhyMay 28 2024, 1:03 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe41b3f34ec5d: [keyserver] refactor identity.js.

Revision Contents
Changeset List

PathSize
keyserver/
src/
user/
58 lines

Diff 40734

View Options

keyserver/src/user/identity.js

Loading...