Differential D12155

[keyserver] uploadSecondaryDeviceKeysAndLogIn client method
ClosedPublic
Actions

Authored by varun on May 21 2024, 3:47 PM.

Details

Reviewers

bartek

Commits

rCOMM97447f13c288: [keyserver] uploadSecondaryDeviceKeysAndLogIn client method

Summary

we will call this after the keyserver has been added to th device list by the primary device

Depends on D12151

Test Plan

tested in next diff by calling the RPC with a signed nonce

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.May 21 2024, 3:47 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 21 2024, 3:47 PM

Harbormaster completed remote builds in B29120: Diff 40487.May 21 2024, 4:39 PM

varun requested review of this revision.May 21 2024, 4:39 PM

varun added a child revision: D12161: [keyserver] call uploadSecondaryDeviceKeysAndLogIn.May 21 2024, 6:57 PM

bartek accepted this revision.May 21 2024, 8:03 PM

bartek added inline comments.

keyserver/addons/rust-node-addon/src/identity_client/login.rs
92 ↗	(On Diff #40487)	Can we add this? Clippy complains and spams the `cargo check` output for the workspace

This revision is now accepted and ready to land.May 21 2024, 8:03 PM

Closed by commit rCOMM97447f13c288: [keyserver] uploadSecondaryDeviceKeysAndLogIn client method. · Explain WhyMay 24 2024, 4:31 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM97447f13c288: [keyserver] uploadSecondaryDeviceKeysAndLogIn client method.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

rust-binding-types.js

12 lines

src/

identity_client/

65 lines

Diff 40648

View Options

keyserver/addons/rust-node-addon/rust-binding-types.js