Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

ashoat added a comment to D9265: [lib/web/native] Add IntegrityStore.

Do you mean just blocking until all hashes are complete (like it is currently) or something smarter (e.g. we send a request to the server to delay the state check)?

Sat, Sep 23, 12:44 PM

Yesterday

ginsu requested review of D9271: [native] improve organization of user profiles work.
Fri, Sep 22, 2:22 PM
ginsu updated the summary of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Fri, Sep 22, 2:07 PM
ginsu planned changes to D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.

changing stack order/will need to rebase

Fri, Sep 22, 1:43 PM
ginsu attached a referenced file: F770513: Screenshot 2023-09-22 at 4.34.33 PM.png.
Fri, Sep 22, 1:36 PM
ginsu updated the summary of D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:35 PM
rohan updated the diff for D9249: [lib] Extend RobotextParams to include parentThreadInfo.

Pass in null parameter from non-problematic call sites
(notifRobotextForMessageInfo and getMessageTitle)

Fri, Sep 22, 1:35 PM
rohan added inline comments to D9249: [lib] Extend RobotextParams to include parentThreadInfo.
Fri, Sep 22, 1:34 PM
ginsu attached a referenced file: F770483: Screenshot 2023-09-22 at 4.25.11 PM.png.
Fri, Sep 22, 1:33 PM
ginsu updated the summary of D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:33 PM
varun requested review of D9270: [native] update password client method and CommRustModule implementation.
Fri, Sep 22, 1:24 PM
ginsu attached a referenced file: F770478: Screenshot 2023-09-22 at 4.15.11 PM.png.
Fri, Sep 22, 1:23 PM
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:23 PM
varun requested review of D9269: [native] helper functions for resolving JS promises with void.
Fri, Sep 22, 1:23 PM
ginsu added inline comments to D9258: [native] introduce UserProfileRelationshipButton.
Fri, Sep 22, 1:22 PM
ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

rebase

Fri, Sep 22, 1:17 PM
ginsu attached a referenced file: F770444: Screenshot 2023-09-22 at 4.15.11 PM.png.
Fri, Sep 22, 1:16 PM
ginsu updated the test plan for D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:15 PM
ginsu added inline comments to D9252: [native] introduce UserProfileMessageButton.
Fri, Sep 22, 1:14 PM
ginsu updated the diff for D9252: [native] introduce UserProfileMessageButton.

we should also not show message button if the user and/or viewer is blocked

Fri, Sep 22, 1:12 PM
varun closed D9264: [keyserver] use correct key for device ID.
Fri, Sep 22, 8:21 AM
varun committed rCOMM2b0757b8e34b: [keyserver] use correct key for device ID (authored by varun).
[keyserver] use correct key for device ID
Fri, Sep 22, 8:21 AM
rohan closed D9220: [keyserver] Encode the device id into the QR code.
Fri, Sep 22, 8:15 AM
rohan committed rCOMMefc194158d4f: [keyserver] Encode the device id into the QR code (authored by rohan).
[keyserver] Encode the device id into the QR code
Fri, Sep 22, 8:15 AM
michal accepted D9246: [native][web] Fix keyserver store tranform error.

Is my understanding correct that there is still a toplevel connection field in redux state? Should we remove it inside of this migration?

Fri, Sep 22, 8:13 AM
inka accepted D9254: [lib] Add unit tests for mention utils.
Fri, Sep 22, 7:55 AM
inka accepted D9218: [keyserver] Render raw chat mention in the notification text.
Fri, Sep 22, 7:49 AM
patryk updated the diff for D9057: [web] Add webMentionTypeaheadRegex tests.

Simplify test cases

Fri, Sep 22, 7:44 AM
inka accepted D9005: [lib] Introduce chat mention utilities for plain text.

Important context in D9007 - we just want to use the alt text for now

Fri, Sep 22, 7:43 AM
rohan closed D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.
Fri, Sep 22, 7:40 AM
rohan committed rCOMM9a08fd6f2883: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex… (authored by rohan).
[keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex…
Fri, Sep 22, 7:40 AM
rohan closed D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.
Fri, Sep 22, 7:40 AM
rohan committed rCOMM1470feaff259: [keyserver] Generate an AES256 key (ephemeral) to encode (authored by rohan).
[keyserver] Generate an AES256 key (ephemeral) to encode
Fri, Sep 22, 7:40 AM
rohan added a comment to D9264: [keyserver] use correct key for device ID.

Sorry, could you actually rebase and use the renamed function getContentSigningKey (I just updated D9220)?

Fri, Sep 22, 7:35 AM
rohan updated the diff for D9220: [keyserver] Encode the device id into the QR code.

Rename getContentPublicKey -> getContentSigningKey and
contentPublicKey -> contentSigningKey

Fri, Sep 22, 7:34 AM
inka accepted D8944: [web] Modify mention typeahead regex.
Fri, Sep 22, 7:32 AM
inka added a comment to D9057: [web] Add webMentionTypeaheadRegex tests.

You could remove the text field and just do textPrefix + mentionText

Fri, Sep 22, 7:32 AM
rohan accepted D9264: [keyserver] use correct key for device ID.
Fri, Sep 22, 7:31 AM
patryk added a comment to D8944: [web] Modify mention typeahead regex.

D9057

Fri, Sep 22, 7:29 AM
kamil accepted D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.

Accepting to unblock, but please look at my comment about moving clearance code to DatabaseManager::clearSensitiveData()

Fri, Sep 22, 7:27 AM