Page MenuHomePhabricator

Active Repositories
View All

Recent Activity
View All

Today

ashoat added a comment to D11694: [native][web] Align logic in SQLiteDataHandlers across platforms.
In D11694#336156, @tomek wrote:

It seems like we can extract the logic to lib by creating a function that accepts three functions: for fetching the stamped user ID, clearing the DB, and stamping the DB. What do you think about doing this?

Fri, Apr 19, 7:04 AM
ashoat added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 6:48 AM
ashoat added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 6:45 AM
ashoat added a comment to D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.

Yeah, I'll make sure to do that

Fri, Apr 19, 6:42 AM
ashoat accepted D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.
Fri, Apr 19, 6:42 AM
ashoat accepted D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 6:36 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 4:58 AM
tomek accepted D11694: [native][web] Align logic in SQLiteDataHandlers across platforms.

It seems like we can extract the logic to lib by creating a function that accepts three functions: for fetching the stamped user ID, clearing the DB, and stamping the DB. What do you think about doing this?

Fri, Apr 19, 4:56 AM
tomek accepted D11691: [lib] Separate recovery types that are managed by KeyserverConnectionHandler.
Fri, Apr 19, 4:49 AM
tomek accepted D11690: [lib] Don't initiate keyserver session recovery if currentUserInfo is not set.
Fri, Apr 19, 4:44 AM
bartek accepted D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.

Nice!

Fri, Apr 19, 3:58 AM
bartek updated the summary of D11687: [identity] Allow UpdateDeviceList RPC to remove devices.
Fri, Apr 19, 3:43 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 3:43 AM
bartek published D11687: [identity] Allow UpdateDeviceList RPC to remove devices for review.
Fri, Apr 19, 3:41 AM
bartek published D11686: [identity] Extract device list verification to separate func for review.
Fri, Apr 19, 3:36 AM
bartek published D11685: [identity] Add device list timestamp verification for review.
Fri, Apr 19, 3:30 AM
marcin updated the diff for D11684: Construct local badge-only notif when notification doesn't have body property.
  1. Remove needsSilentBadgeUpdate function and replace it with inline checks.
  2. Bring back useful comment.
Fri, Apr 19, 3:05 AM
marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 3:05 AM
tomek added inline comments to D11651: [lib] Include `[creator/target]FID` in `messageContentForServerDB` when update relationship op is `farcaster_mutual`.
Fri, Apr 19, 3:04 AM
marcin accepted D11693: [native] Wait for authoritative keyserver login before setting avatar in registration flow.
Fri, Apr 19, 2:46 AM

Yesterday

will closed D11672: create new aux user store action for clearing fids.
Thu, Apr 18, 9:13 PM
will committed rCOMM2b05aaf6d911: create new aux user store action for clearing fids (authored by will).
create new aux user store action for clearing fids
Thu, Apr 18, 9:13 PM
will closed D11671: Makes fid optionally null so that we can delete the fid later.
Thu, Apr 18, 9:13 PM
will committed rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later (authored by will).
Makes fid optionally null so that we can delete the fid later
Thu, Apr 18, 9:13 PM
will updated the diff for D11672: create new aux user store action for clearing fids.

rename clear to not include friends

Thu, Apr 18, 8:32 PM
varun requested review of D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.
Thu, Apr 18, 5:07 PM
atul added a comment to D11681: [keyserver] Remove `UPDATE_RELATIONSHIP.farcaster_mutual` messages from KeyserverDB.

@ashoat, would it make sense to backup prod DB before deploying this migration to keyserver as a precaution?

Thu, Apr 18, 1:46 PM
atul added inline comments to D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.
Thu, Apr 18, 1:41 PM
atul updated the diff for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

fix typo + remove second invaraint

Thu, Apr 18, 1:40 PM
atul updated the diff for D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.

get rid of first invariant

Thu, Apr 18, 1:38 PM
atul attached a referenced file: F1574319: fbacb2.png.
Thu, Apr 18, 1:37 PM
atul attached a referenced file: F1574322: 3f0434.png.
Thu, Apr 18, 1:37 PM
atul added inline comments to D11680: [web] Redux migration to clear `UNSUPPORTED<UPDATE_RELATIONSHIP>` messages.
Thu, Apr 18, 1:37 PM
ashoat added inline comments to D11691: [lib] Separate recovery types that are managed by KeyserverConnectionHandler.
Thu, Apr 18, 1:34 PM
ashoat added inline comments to D11691: [lib] Separate recovery types that are managed by KeyserverConnectionHandler.
Thu, Apr 18, 1:33 PM
ginsu closed D11689: [lib/web] fix error handling indirection.
Thu, Apr 18, 1:33 PM
ginsu committed rCOMMb0c7149f1f9c: [lib/web] fix error handling indirection (authored by ginsu).
[lib/web] fix error handling indirection
Thu, Apr 18, 1:33 PM
ginsu updated the diff for D11689: [lib/web] fix error handling indirection.

rebase before landing

Thu, Apr 18, 1:31 PM
ashoat requested review of D11694: [native][web] Align logic in SQLiteDataHandlers across platforms.
Thu, Apr 18, 1:26 PM
atul closed D11624: [lib] Fix `farcasterRelationshipRequestValidator`.
Thu, Apr 18, 1:26 PM