Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

bartek accepted D14617: [lib] Move deciding where to upload media ad metadata to a spec.

Looks good 👍

Tue, Apr 29, 7:55 AM
bartek closed D14621: [native] Verify prekey signatures when rotating.
Tue, Apr 29, 7:49 AM
bartek committed rCOMMd056fe07471c: [native] Verify prekey signatures when rotating (authored by bartek).
[native] Verify prekey signatures when rotating
Tue, Apr 29, 7:49 AM
bartek closed D14619: [native] Move prekey c++ helpers to separate files.
Tue, Apr 29, 7:49 AM
bartek closed D14620: [native] Add c++ util to parse ed25519 key from JSON blob.
Tue, Apr 29, 7:49 AM
bartek committed rCOMM7a6551bb4339: [native] Move prekey c++ helpers to separate files (authored by bartek).
[native] Move prekey c++ helpers to separate files
Tue, Apr 29, 7:49 AM
bartek committed rCOMMa6095a57d06a: [native] Add c++ util to parse ed25519 key from JSON blob (authored by bartek).
[native] Add c++ util to parse ed25519 key from JSON blob
Tue, Apr 29, 7:49 AM
bartek closed D14618: [native] Make CryptoModule::verifySignature accept OlmBuffer message.
Tue, Apr 29, 7:49 AM
bartek committed rCOMM1a9b49f0b07d: [native] Make CryptoModule::verifySignature accept OlmBuffer message (authored by bartek).
[native] Make CryptoModule::verifySignature accept OlmBuffer message
Tue, Apr 29, 7:49 AM
kamil closed D14615: [lib][web][native] add comment in `AppState`s to update Notion doc.
Tue, Apr 29, 7:46 AM
kamil committed rCOMMd43b444cee38: [lib][web][native] add comment in `AppState`s to update Notion doc (authored by kamil).
[lib][web][native] add comment in `AppState`s to update Notion doc
Tue, Apr 29, 7:45 AM
kamil accepted D14621: [native] Verify prekey signatures when rotating.
Tue, Apr 29, 7:43 AM
kamil accepted D14620: [native] Add c++ util to parse ed25519 key from JSON blob.
Tue, Apr 29, 7:40 AM
tomek accepted D14615: [lib][web][native] add comment in `AppState`s to update Notion doc.
Tue, Apr 29, 7:40 AM
kamil accepted D14619: [native] Move prekey c++ helpers to separate files.
Tue, Apr 29, 7:39 AM
kamil accepted D14618: [native] Make CryptoModule::verifySignature accept OlmBuffer message.
Tue, Apr 29, 7:37 AM
bartek published D14620: [native] Add c++ util to parse ed25519 key from JSON blob for review.
Tue, Apr 29, 7:31 AM
bartek published D14621: [native] Verify prekey signatures when rotating for review.
Tue, Apr 29, 7:30 AM
bartek published D14619: [native] Move prekey c++ helpers to separate files for review.
Tue, Apr 29, 7:28 AM
bartek published D14618: [native] Make CryptoModule::verifySignature accept OlmBuffer message for review.
Tue, Apr 29, 7:28 AM
bartek closed D14610: [web] Rotate prekeys with invalid signature.
Tue, Apr 29, 7:11 AM
bartek committed rCOMMcd492b16985e: [web] Rotate prekeys with invalid signature (authored by bartek).
[web] Rotate prekeys with invalid signature
Tue, Apr 29, 7:11 AM
bartek closed D14616: [lib] Fix QR generation happening before DB reset after logout.
Tue, Apr 29, 7:11 AM
bartek committed rCOMM3d78a988eec2: [lib] Fix QR generation happening before DB reset after logout (authored by bartek).
[lib] Fix QR generation happening before DB reset after logout
Tue, Apr 29, 7:10 AM
kamil accepted D14616: [lib] Fix QR generation happening before DB reset after logout.
Tue, Apr 29, 5:22 AM
tomek requested review of D14617: [lib] Move deciding where to upload media ad metadata to a spec.
Tue, Apr 29, 5:08 AM
angelika accepted D14614: [lib] Move reacting to messages to specs.
Tue, Apr 29, 4:55 AM
angelika accepted D14613: [lib] Extract ID utils.
Tue, Apr 29, 4:53 AM
angelika accepted D14612: [lib] Extract common logic from reaction hooks.

LGTM, but we can probably simplify it more later.
In staff-utils.js we have a way to show alert on every platform (getConfig().showAlert(title, message)), even though it's part of lib. Each platform implements its own way of showing the alert: on web it's window.alert(...), on mobile it's Alert.alert. Maybe we can do something similar for those alerts? Showing an alert seems like a common functionality, so maybe we can simplify it in other places too.

Tue, Apr 29, 4:38 AM
bartek published D14616: [lib] Fix QR generation happening before DB reset after logout for review.
Tue, Apr 29, 4:32 AM
angelika accepted D14611: [lib] Simplify thread settings types.
Tue, Apr 29, 4:16 AM
kamil published D14615: [lib][web][native] add comment in `AppState`s to update Notion doc for review.
Tue, Apr 29, 3:23 AM
angelika accepted D14609: [lib] Move most of the UI differences to specs.
Tue, Apr 29, 2:46 AM
tomek requested review of D14614: [lib] Move reacting to messages to specs.
Tue, Apr 29, 2:43 AM
tomek requested review of D14613: [lib] Extract ID utils.
Tue, Apr 29, 2:42 AM
angelika accepted D14608: [lib] Move sidebar source deletion check to a spec.
Tue, Apr 29, 2:39 AM
angelika accepted D14607: [lib] Move message preview flag to specs.
Tue, Apr 29, 2:26 AM
angelika accepted D14606: [lib] Move setting unread status to a spec.
Tue, Apr 29, 2:21 AM
angelika accepted D14605: [lib] Simplify unread status types.
Tue, Apr 29, 2:18 AM
kamil accepted D14610: [web] Rotate prekeys with invalid signature.
Tue, Apr 29, 1:26 AM