Differential D7022 Diff 23790 shared/comm-opaque2/Cargo.toml

Changeset View

Standalone View

shared/comm-opaque2/Cargo.toml

This file was added.

				[package]
				name = "comm-opaque"
				varunUnsubmitted Done Inline Actions should we give this a different name? or alternatively we could just version comm-opaque, git tag it, and not create a new cargo project? i actually think the latter makes more sense... `git tag -a comm-opaque-v0.1.0 -m "comm-opaque version 0.1.0"` then dependencies would consume this library like this `comm-opaque = { git = "https://github.com/CommE2E/comm.git", tag = "comm-opaque-v0.1.0" }` varun: should we give this a different name? or alternatively we could just version comm-opaque, git…
				jonAuthorUnsubmitted Done Inline Actions since we reference it by path currently, I don't think it makes too much of a difference. I would like to avoid tagging in case there is a use case for touching that code again, then it we will have an awkward time referencing it. jon: since we reference it by path currently, I don't think it makes too much of a difference. I…
				version = "0.1.0"
				edition = "2021"

				[lib]
				crate-type = ["cdylib", "rlib"]
				varunUnsubmitted Done Inline Actions can you explain why we are building these targets? `cdylib` make sense, i'm guessing that's for `wasm` stuff. however `rlib` is used to produce statically linked executables as well as `staticlib` outputs, so not sure why we need it. also don't we need just normal `lib` here? varun: can you explain why we are building these targets? `cdylib` make sense, i'm guessing that's for…
				jonAuthorUnsubmitted Done Inline Actions "cdylib" is meant for wasm_bindgen. `rlib` is the compiled intermediate of a crate, so we should be retain this because we will still be using this from other places in the code as a crate. https://users.rust-lang.org/t/what-is-the-difference-between-dylib-and-cdylib/28847/3 jon: "cdylib" is meant for wasm_bindgen. `rlib` is the compiled intermediate of a crate, so we…
				varunUnsubmitted Done Inline Actions i think we should use `lib`, not `rlib` For current compiler versions there is no difference in what they produce, because lib is an alias for rlib. The difference is in what changes future compiler versions are allowed to make. The rlib type will always produce the same format as it does in the current version, but the lib type may be changed to a different format (but it will always be an alias of one of the other types). For example, maybe dynamic libraries will become the recommended style, and the alias will change to one of those. In general, use lib unless you specifically need the output to be rlib (but I don't know why you would need to do that). varun: i think we should use `lib`, not `rlib` [For current compiler versions there is no difference…
				jonAuthorUnsubmitted Done Inline Actions Sounds good to me. jon: Sounds good to me.

				[dependencies]
				argon2 = "0.4"
				log = "0.4"
				opaque-ke = { version = "2.0", features = [ "argon2" ] }
				rand = "0.8"
				tonic = { version = "0.8", default-features = false }