Changeset View
Standalone View
lib/types/tunnelbroker-messages.js
- This file was added.
// @flow | |||||
export type SessionRequestMessage = { | |||||
ashoat: > I would just need to rename it in both places. But now would be the time to rename it rather… | |||||
+type: 'sessionRequest', | |||||
+deviceID: string, | |||||
+accessToken: string, | |||||
+notifyToken?: string, | |||||
ashoatUnsubmitted Done Inline ActionsFor this notifyToken to have any significance, we need to know what kind of notifyToken it is. That's probably when we previously needed the OS? ashoat: For this `notifyToken` to have any significance, we need to know what kind of `notifyToken` it… | |||||
jonAuthorUnsubmitted Done Inline ActionsI think we need to iron-out some details about how tunnelbroker would be handling notifications. At the very least, it shouldn't only be getting handle for active connections. We will likely need to persist this information in some way. Not sure if we want to do this on the identity side when someone first registers (or login) with a device, or have tunnelbroker have this information tracked separately (this is some duplication, but probably the best route forward to avoid hammering identity service). Either way, since notifications are out-of-scope, I'm okay just removing it for now, and then adding proper support at a later date. jon: I think we need to iron-out some details about how tunnelbroker would be handling notifications. | |||||
+deviceType: 'mobile' | 'web' | 'keyserver', | |||||
}; |
Can we start by renaming this to ConnectionInitializationMessage?