Changeset View
Changeset View
Standalone View
Standalone View
lib/types/tunnelbroker-messages.js
- This file was added.
// @flow | |||||
export type TBConnectionInitializationMessage = { | |||||
+type: 'sessionRequest', | |||||
+deviceID: string, | |||||
+accessToken: string, | |||||
+notifyToken?: string, | |||||
ashoat: There is no point including a `notifyToken` without the OS. I think we should bring back the… | |||||
jonAuthorUnsubmitted Done Inline Actions
I was just going to remove notifyToken altogether, until it's clear what we need.
We've also moved forward with things which we had to undo later: opaque_ke 1.2, SessionInitializtion However, since the fields are optional, I don't see the harm in it either. Changing it should be low pain-threshold as well. jon: > There is no point including a notifyToken without the OS. I think we should bring back the… | |||||
jonAuthorUnsubmitted Done Inline Actionsdidn't realize I hadn't posted this earlier, we already talked about it in the one on one jon: didn't realize I hadn't posted this earlier, we already talked about it in the one on one | |||||
+deviceType: 'mobile' | 'web' | 'keyserver', | |||||
}; |
There is no point including a notifyToken without the OS. I think we should bring back the options you had originally, that are listed in this Linear comment. I realize we can bring this back later, but every time we do something like that we create more work for ourselves, since we'll need to find a way to get existing clients to provide that info later. Might as well get it in now