Change Details

issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar Because of how we use the grid, and because the designs call for the switcher in the settings tab to a sidebar, and in inbox tab to be a topbar, the `SettingsSwitcher` is now inside of the `AccountSettings` and `DangerZone`. Our grid: https://github.com/CommE2E/comm/blob/master/web/style.css#L54 So the `SettingsSwitcher` has to be a part of `app` grid area. Changing the way we use the grid - or not using the grid - can be done, but it seems like a really big side quest to my community drawer task. So for now I think this is a good enough solution. On the other hand, it has been proposed this month on the monthly planning meeting, that we might want to make the web app more responsive to resizing. If we do decide take care of it, this could be improved in the process.

issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar The `AppSwitcher` is now displayed in the topbar. The `SettingsSwitcher` is displayed as it used to, but I moved it out of the sidebar because of how we use the grid. Our grid: https://github.com/CommE2E/comm/blob/master/web/style.css#L54 So the SettingsSwitcher has to be a part of app grid area, or the grid layout has to change. Changing the way we use the grid - or not using the grid - can be done, but it seems like a really big side quest to my community drawer task. So for now I think this is a good enough solution. It is also consistent between the `AppSwitcher` and `SettingsSwitcher`, so I think it's not necessearly bad.

issue: https://linear.app/comm/issue/ENG-2739/move-navigationpanel-from-the-sidebar-to-a-top-bar Because of how we use the grid, and because the designs call for the switcherThe `AppSwitcher` is now displayed in the settings tab to a sidebar,e topbar. and in inbox tab to be a topbarThe `SettingsSwitcher` is displayed as it used to, the `SettingsSwitcher` is now inbut I moved it out of the side of the `AccountSettings` and `DangerZone`. bar because of how we use the grid. Our grid: https://github.com/CommE2E/comm/blob/master/web/style.css#L54 So the `SettingsSwitcher` has to be a part of `app`app grid area., or the grid layout has to change. Changing the way we use the grid - or not using the grid - can be done, but it seems like a really big side quest to my community drawer task. So for now I think this is a good enough solution. On the other hand, it has been proposed this month on the monthly planning meeting, that we might want to make the web app more responsive to resizing. It is also consistent between the `AppSwitcher` and `SettingsSwitcher`, If we do decide take care of it, this could be improved in the process.so I think it's not necessearly bad.