Change Details

Turns out that [macOS](https://github.com/mathiasbynens/emoji-regex/issues/28#issuecomment-321435043) [appends](https://github.com/mathiasbynens/emoji-regex/issues/68) the `U+FE0F` the character to some Unicode emojis when you select them from the native OS emoji selector. It's not clear why Apple does this, or why it only happens for a certain set of emoji. Second GitHub link This still counts as [valid emoji Unicode](https://github.com/mathiasbynens/emoji-regex/issues/28#issuecomment-322716929). However, our `onlyOneEmojiRegex` thinks it's two emojis. Our implementation of `onlyOneEmojiRegex` involves introspecting into the RegExp string that `emoji-regex` uses, and is not an officially supported approach by that package. `emoji-regex` supports matching emojis in text, and checking if the text includes only emoji. But checking for precisely one emoji is more complicated, and our approach (which is basically just extracting the raw RegExp and putting it inside of `/^()$/`) doesn't work in some scenarios where `U+FE0F` is suffixed. Luckily we don't use the native macOS emoji selector in any of our UIs, but it does look like @ginsu used it to select some of the emojis. The diff adds a unit test to make sure all of the default emojis pass `onlyOneEmojiRegex`, and fixes all failing emojis.

Turns out that [macOS](https://github.com/mathiasbynens/emoji-regex/issues/28#issuecomment-321435043) [appends](https://github.com/mathiasbynens/emoji-regex/issues/68) the `U+FE0F` the character to some Unicode emojis when you select them from the native OS emoji selector. It's not clear why Apple does this, or why it only happens for a certain set of emoji. This still counts as [valid emoji Unicode](https://github.com/mathiasbynens/emoji-regex/issues/28#issuecomment-322716929). However, our `onlyOneEmojiRegex` thinks it's two emojis. Our implementation of `onlyOneEmojiRegex` involves introspecting into the RegExp string that `emoji-regex` uses, and is not an officially supported approach by that package. `emoji-regex` supports matching emojis in text, and checking if the text includes only emoji. But checking for precisely one emoji is more complicated, and our approach (which is basically just extracting the raw RegExp and putting it inside of `/^()$/`) doesn't work in some scenarios where `U+FE0F` is suffixed. Luckily we don't use the native macOS emoji selector in any of our UIs, but it does look like @ginsu used it to select some of the emojis. The diff adds a unit test to make sure all of the default emojis pass `onlyOneEmojiRegex`, and fixes all failing emojis.

Turns out that [macOS](https://github.com/mathiasbynens/emoji-regex/issues/28#issuecomment-321435043) [appends](https://github.com/mathiasbynens/emoji-regex/issues/68) the `U+FE0F` the character to some Unicode emojis when you select them from the native OS emoji selector. It's not clear why Apple does this, or why it only happens for a certain set of emoji. Second GitHub link This still counts as [valid emoji Unicode](https://github.com/mathiasbynens/emoji-regex/issues/28#issuecomment-322716929). However, our `onlyOneEmojiRegex` thinks it's two emojis. Our implementation of `onlyOneEmojiRegex` involves introspecting into the RegExp string that `emoji-regex` uses, and is not an officially supported approach by that package. `emoji-regex` supports matching emojis in text, and checking if the text includes only emoji. But checking for precisely one emoji is more complicated, and our approach (which is basically just extracting the raw RegExp and putting it inside of `/^()$/`) doesn't work in some scenarios where `U+FE0F` is suffixed. Luckily we don't use the native macOS emoji selector in any of our UIs, but it does look like @ginsu used it to select some of the emojis. The diff adds a unit test to make sure all of the default emojis pass `onlyOneEmojiRegex`, and fixes all failing emojis.