Change Details

Run web app, checked that removing these styles makes no difference in inbox and in settings.

Run web app, checked that removing these styles makes no difference in inbox and in settings. 1. checked in all files that import left-layout-aside.css which of them use the `container` style, and `container` style from left-layout-aside.css is only used in left-layout-aside.js 2. `container` style is used on the <aside> element, and the styles I removed concern its foreground objects and svgs, so I check its children: 3. its children are CommunityPicker, SettingsSwitcher, AppSwitcher 4. CommunityPicker: the outer div returned from community picker has a [[ https://github.com/CommE2E/comm/blob/master/web/sidebar/community-picker.css#L20 | style that overrides svgs colours and padding ]]. CommunityPicker has no other foreground objects than the two svgs: inbox and setting icons. So the styles I removed don’t concern CommunityPicker. 5. SettingsSwitcher displays two items inside of the NavigationPanel. The active item [[ https://github.com/CommE2E/comm/blob/master/web/sidebar/navigation-panel.react.js#L41 | gets colour from NavigationPanel. ]] And the non-active tab gets its colour in SettingsSwitcher: https://github.com/CommE2E/comm/blob/master/web/sidebar/settings-switcher.react.js#L26 https://github.com/CommE2E/comm/blob/master/web/sidebar/settings-switcher.react.js#L45 https://github.com/CommE2E/comm/blob/master/web/sidebar/left-layout-aside.css#L28 6. AppSwitcher: displays three items, and does the same thing as SettingsSwitcher 7. There are no deeper nested children in any of those three children of the <aside> element.

Run web app, checked that removing these styles makes no difference in inbox and in settings. 1. checked in all files that import left-layout-aside.css which of them use the `container` style, and `container` style from left-layout-aside.css is only used in left-layout-aside.js 2. `container` style is used on the <aside> element, and the styles I removed concern its foreground objects and svgs, so I check its children: 3. its children are CommunityPicker, SettingsSwitcher, AppSwitcher 4. CommunityPicker: the outer div returned from community picker has a [[ https://github.com/CommE2E/comm/blob/master/web/sidebar/community-picker.css#L20 | style that overrides svgs colours and padding ]]. CommunityPicker has no other foreground objects than the two svgs: inbox and setting icons. So the styles I removed don’t concern CommunityPicker. 5. SettingsSwitcher displays two items inside of the NavigationPanel. The active item [[ https://github.com/CommE2E/comm/blob/master/web/sidebar/navigation-panel.react.js#L41 | gets colour from NavigationPanel. ]] And the non-active tab gets its colour in SettingsSwitcher: https://github.com/CommE2E/comm/blob/master/web/sidebar/settings-switcher.react.js#L26 https://github.com/CommE2E/comm/blob/master/web/sidebar/settings-switcher.react.js#L45 https://github.com/CommE2E/comm/blob/master/web/sidebar/left-layout-aside.css#L28 6. AppSwitcher: displays three items, and does the same thing as SettingsSwitcher 7. There are no deeper nested children in any of those three children of the <aside> element.