Change Details

Fix side bar height chopping off per the issue. https://linear.app/comm/issue/ENG-766/sidebar-height-was-chopped-in-order-to-have-a-continuous-line https://linear.app/comm/issue/ENG-766/sidebar-height-was-chopped-in-order-to-have-a-continuous-line https://phabricator.ashoat.com/file/data/5fdirsmbi6qpkmd3im55/PHID-FILE-nvwfipkwd6aamahkzjdr/Image_2022-03-18_at_10.08.03_AM.jpg Note: This diff introduces a regression in sidebars where the arrows aren't continuous. This issue will be fixed in a future diff in the stack. {F23020} {F23021}

Fix sidebar height chopping off per the issue. https://linear.app/comm/issue/ENG-766/sidebar-height-was-chopped-in-order-to-have-a-continuous-line https://linear.app/comm/issue/ENG-766/sidebar-height-was-chopped-in-order-to-have-a-continuous-line https://phabricator.ashoat.com/file/data/5fdirsmbi6qpkmd3im55/PHID-FILE-nvwfipkwd6aamahkzjdr/Image_2022-03-18_at_10.08.03_AM.jpg Note: This diff introduces a regression in sidebars where the arrows aren't continuous. This issue will be fixed in a future diff in the stack. {F23020} {F23021} Follow up on initial post: {F38781} Is the updated sidebar without chopped height. (this is a screenshot of the end of the stack). You'll notice an ever so thinner extender in the second thread. That's something I'll address moving forward either: - first try: using atul's SVG (https://blob.sh/atul/long_arrow.svg) with just an image tag like we do here: https://github.com/CommE2E/comm/blob/master/landing/read-docs-btn.react.js#L16 - second: Following up with @palys-swm comment here: D3539 -- `For me it looks like the best way to make it consistent with the rest of an arrow is to draw this whole shape via CSS.` I know it's a subtle visual bug, but it will unblock my stack, and straighten out a lot of issues with the chat thread list items.

Fix side bar height chopping off per the issue. https://linear.app/comm/issue/ENG-766/sidebar-height-was-chopped-in-order-to-have-a-continuous-line https://linear.app/comm/issue/ENG-766/sidebar-height-was-chopped-in-order-to-have-a-continuous-line https://phabricator.ashoat.com/file/data/5fdirsmbi6qpkmd3im55/PHID-FILE-nvwfipkwd6aamahkzjdr/Image_2022-03-18_at_10.08.03_AM.jpg Note: This diff introduces a regression in sidebars where the arrows aren't continuous. This issue will be fixed in a future diff in the stack. {F23020} {F23021} Follow up on initial post: {F38781} Is the updated sidebar without chopped height. (this is a screenshot of the end of the stack). You'll notice an ever so thinner extender in the second thread. That's something I'll address moving forward either: - first try: using atul's SVG (https://blob.sh/atul/long_arrow.svg) with just an image tag like we do here: https://github.com/CommE2E/comm/blob/master/landing/read-docs-btn.react.js#L16 - second: Following up with @palys-swm comment here: D3539 -- `For me it looks like the best way to make it consistent with the rest of an arrow is to draw this whole shape via CSS.` I know it's a subtle visual bug, but it will unblock my stack, and straighten out a lot of issues with the chat thread list items.