Change Details

As I was testing the loaders in Thread Settings for [[ https://linear.app/comm/issue/ENG-3741/change-thread-settings-loading-state-are-shared-across-different | ENG-3741 ]] I came across an issue where if the user navigated away from thread settings and back to it, then the button would not render while the new name was being saved. This was happening because `nameEditValue` was not being set since we navigated away from the screen so we were only just rendering `SaveSettingButton` which in turn render nothing since `canChangeSettings` is set to false while the name is being set. To fix this I created a separate function that just handles the rendering of the button and used that function within `renderContent` and now an `ActivityIndicator` will always render while the setting is being saved

As I was testing the loaders in Thread Settings for [[ https://linear.app/comm/issue/ENG-3741/change-thread-settings-loading-state-are-shared-across-different | ENG-3741 ]] I came across an issue where if the user navigated away from thread settings and back to it, then the button would not render while the new name was being saved. This was happening because `nameEditValue` was not being set since we navigated away from the screen so we were only just rendering `SaveSettingButton` which in turn render nothing since `canChangeSettings` is set to false while the name is being set. To fix this I created a separate function that just handles the rendering of the button and used that function within `renderContent` and now an `ActivityIndicator` will always render while the setting is being saved A follow up diff for fixing the description will be up shortly

As I was testing the loaders in Thread Settings for [[ https://linear.app/comm/issue/ENG-3741/change-thread-settings-loading-state-are-shared-across-different | ENG-3741 ]] I came across an issue where if the user navigated away from thread settings and back to it, then the button would not render while the new name was being saved. This was happening because `nameEditValue` was not being set since we navigated away from the screen so we were only just rendering `SaveSettingButton` which in turn render nothing since `canChangeSettings` is set to false while the name is being set. To fix this I created a separate function that just handles the rendering of the button and used that function within `renderContent` and now an `ActivityIndicator` will always render while the setting is being saved A follow up diff for fixing the description will be up shortly