Page MenuHomePhabricator
Files F2752275

D3765.id11736.diff
No OneTemporary
Actions

D3765.id11736.diff
View Options

diff --git a/web/modals/threads/thread-settings-modal.react.js b/web/modals/threads/thread-settings-modal.react.js
--- a/web/modals/threads/thread-settings-modal.react.js
+++ b/web/modals/threads/thread-settings-modal.react.js
@@ -95,6 +95,7 @@
+setQueuedChanges: SetState<ThreadChanges>,
+namePlaceholder: string,
+changeQueued: boolean,
+ +onChangeName: (event: SyntheticEvent<HTMLInputElement>) => void,
};
class ThreadSettingsModal extends React.PureComponent<Props> {
nameInput: ?HTMLInputElement;
@@ -166,7 +167,7 @@
<ThreadSettingsGeneralTab
threadNameValue={firstLine(this.possiblyChangedValue('name'))}
threadNamePlaceholder={this.props.namePlaceholder}
- threadNameOnChange={this.onChangeName}
+ threadNameOnChange={this.props.onChangeName}
threadNameDisabled={inputDisabled}
threadNameInputRef={this.nameInputRef}
threadDescriptionValue={this.possiblyChangedValue('description')}
@@ -293,18 +294,6 @@
this.accountPasswordInput = accountPasswordInput;
};
- onChangeName = (event: SyntheticEvent<HTMLInputElement>) => {
- const target = event.currentTarget;
- const newValue =
- target.value !== this.props.threadInfo.name ? target.value : undefined;
- this.props.setQueuedChanges(
- Object.freeze({
- ...this.props.queuedChanges,
- name: firstLine(newValue),
- }),
- );
- };
-
onChangeDescription = (event: SyntheticEvent<HTMLTextAreaElement>) => {
const target = event.currentTarget;
const newValue =
@@ -448,6 +437,20 @@
[queuedChanges],
);
+ const onChangeName = React.useCallback(
+ (event: SyntheticEvent<HTMLInputElement>) => {
+ invariant(threadInfo, 'threadInfo should exist in onChangeName');
+ const target = event.currentTarget;
+ setQueuedChanges({
+ ...queuedChanges,
+ name: firstLine(
+ target.value !== threadInfo.name ? target.value : undefined,
+ ),
+ });
+ },
+ [queuedChanges, threadInfo],
+ );
+
if (!threadInfo) {
return (
<Modal onClose={modalContext.clearModal} name="Invalid thread">
@@ -479,6 +482,7 @@
setQueuedChanges={setQueuedChanges}
namePlaceholder={namePlaceholder}
changeQueued={changeQueued}
+ onChangeName={onChangeName}
/>
);
},

File Metadata

Mime Type
text/plain
Expires
Thu, Sep 19, 3:39 PM (6 h, 54 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2140373
Default Alt Text
D3765.id11736.diff (2 KB)

Event Timeline