Page MenuHomePhabricator
Files F2761354

D3764.id11645.diff
No OneTemporary
Actions

D3764.id11645.diff
View Options

diff --git a/web/modals/threads/thread-settings-modal.react.js b/web/modals/threads/thread-settings-modal.react.js
--- a/web/modals/threads/thread-settings-modal.react.js
+++ b/web/modals/threads/thread-settings-modal.react.js
@@ -95,6 +95,7 @@
+setQueuedChanges: SetState<ThreadChanges>,
+namePlaceholder: string,
+changeQueued: boolean,
+ +setTab: (tabType: TabType) => void,
};
class ThreadSettingsModal extends React.PureComponent<Props> {
nameInput: ?HTMLInputElement;
@@ -124,7 +125,7 @@
);
if (!permissionForDeleteTab && prevPermissionForDeleteTab) {
- this.setTab('general');
+ this.props.setTab('general');
}
}
@@ -223,7 +224,7 @@
<Tab
name="General"
tabType="general"
- onClick={this.setTab}
+ onClick={this.props.setTab}
selected={this.props.currentTabType === 'general'}
key="general"
/>,
@@ -244,7 +245,7 @@
<Tab
name="Privacy"
tabType="privacy"
- onClick={this.setTab}
+ onClick={this.props.setTab}
selected={this.props.currentTabType === 'privacy'}
key="privacy"
/>,
@@ -256,7 +257,7 @@
<Tab
name="Delete"
tabType="delete"
- onClick={this.setTab}
+ onClick={this.props.setTab}
selected={this.props.currentTabType === 'delete'}
key="delete"
/>,
@@ -281,10 +282,6 @@
);
}
- setTab = (tabType: TabType) => {
- this.props.setCurrentTabType(tabType);
- };
-
nameInputRef = (nameInput: ?HTMLInputElement) => {
this.nameInput = nameInput;
};
@@ -449,6 +446,10 @@
[queuedChanges],
);
+ const setTab = React.useCallback((tabType: TabType) => {
+ setCurrentTabType(tabType);
+ }, []);
+
if (!threadInfo) {
return (
<Modal onClose={modalContext.clearModal} name="Invalid thread">
@@ -480,6 +481,7 @@
setQueuedChanges={setQueuedChanges}
namePlaceholder={namePlaceholder}
changeQueued={changeQueued}
+ setTab={setTab}
/>
);
},

File Metadata

Mime Type
text/plain
Expires
Fri, Sep 20, 8:12 AM (17 h, 59 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2140766
Default Alt Text
D3764.id11645.diff (2 KB)

Event Timeline