Page MenuHomePhabricator

D3821.diff
No OneTemporary

D3821.diff

diff --git a/web/modals/threads/thread-settings-delete-tab.react.js b/web/modals/threads/thread-settings-delete-tab.react.js
--- a/web/modals/threads/thread-settings-delete-tab.react.js
+++ b/web/modals/threads/thread-settings-delete-tab.react.js
@@ -8,18 +8,12 @@
+accountPassword: string,
+onChangeAccountPassword: (event: SyntheticEvent<HTMLInputElement>) => void,
+inputDisabled: boolean,
- +accountPasswordInputRef: (accountPasswordInput: ?HTMLInputElement) => void,
};
function ThreadSettingsDeleteTab(
props: ThreadSettingsDeleteTabProps,
): React.Node {
- const {
- accountPassword,
- onChangeAccountPassword,
- inputDisabled,
- accountPasswordInputRef,
- } = props;
+ const { accountPassword, onChangeAccountPassword, inputDisabled } = props;
return (
<>
<div>
@@ -40,7 +34,6 @@
value={accountPassword}
onChange={onChangeAccountPassword}
disabled={inputDisabled}
- ref={accountPasswordInputRef}
/>
</div>
</div>
diff --git a/web/modals/threads/thread-settings-general-tab.react.js b/web/modals/threads/thread-settings-general-tab.react.js
--- a/web/modals/threads/thread-settings-general-tab.react.js
+++ b/web/modals/threads/thread-settings-general-tab.react.js
@@ -11,7 +11,6 @@
+threadNamePlaceholder: string,
+threadNameOnChange: (event: SyntheticEvent<HTMLInputElement>) => void,
+threadNameDisabled: boolean,
- +threadNameInputRef: (nameInput: ?HTMLInputElement) => void,
+threadDescriptionValue: string,
+threadDescriptionOnChange: (
event: SyntheticEvent<HTMLTextAreaElement>,
@@ -28,7 +27,6 @@
threadNamePlaceholder,
threadNameOnChange,
threadNameDisabled,
- threadNameInputRef,
threadDescriptionValue,
threadDescriptionOnChange,
threadDescriptionDisabled,
@@ -47,7 +45,6 @@
placeholder={threadNamePlaceholder}
onChange={threadNameOnChange}
disabled={threadNameDisabled}
- ref={threadNameInputRef}
/>
</div>
</div>
diff --git a/web/modals/threads/thread-settings-modal.react.js b/web/modals/threads/thread-settings-modal.react.js
--- a/web/modals/threads/thread-settings-modal.react.js
+++ b/web/modals/threads/thread-settings-modal.react.js
@@ -107,9 +107,6 @@
+onSubmit: (event: SyntheticEvent<HTMLElement>) => void,
};
class ThreadSettingsModal extends React.PureComponent<Props> {
- nameInput: ?HTMLInputElement;
- accountPasswordInput: ?HTMLInputElement;
-
constructor(props: Props) {
super(props);
}
@@ -137,7 +134,6 @@
threadNamePlaceholder={this.props.namePlaceholder}
threadNameOnChange={this.props.onChangeName}
threadNameDisabled={inputDisabled}
- threadNameInputRef={this.nameInputRef}
threadDescriptionValue={this.possiblyChangedValue('description')}
threadDescriptionOnChange={this.props.onChangeDescription}
threadDescriptionDisabled={inputDisabled}
@@ -159,7 +155,6 @@
accountPassword={this.props.accountPassword}
onChangeAccountPassword={this.props.onChangeAccountPassword}
inputDisabled={inputDisabled}
- accountPasswordInputRef={this.accountPasswordInputRef}
/>
);
}
@@ -252,14 +247,6 @@
</Modal>
);
}
-
- nameInputRef = (nameInput: ?HTMLInputElement) => {
- this.nameInput = nameInput;
- };
-
- accountPasswordInputRef = (accountPasswordInput: ?HTMLInputElement) => {
- this.accountPasswordInput = accountPasswordInput;
- };
}
const deleteThreadLoadingStatusSelector = createLoadingStatusSelector(

File Metadata

Mime Type
text/plain
Expires
Fri, Sep 20, 8:25 AM (18 h, 1 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2147403
Default Alt Text
D3821.diff (3 KB)

Event Timeline