Page MenuHomePhabricator
Files F2772623

D13134.id43561.diff
No OneTemporary
Actions

D13134.id43561.diff
View Options

diff --git a/keyserver/src/cron/backups.js b/keyserver/src/cron/backups.js
--- a/keyserver/src/cron/backups.js
+++ b/keyserver/src/cron/backups.js
@@ -87,26 +87,28 @@
extraParams: $ReadOnlyArray<string>,
pipeParams?: { end?: boolean, ... },
): Promise<void> {
- const mysqlDump = childProcess.spawn(
- 'mysqldump',
- [
- '-h',
- dbConfig.host,
- '-u',
- dbConfig.user,
- `-p${dbConfig.password}`,
- '--single-transaction',
- '--no-tablespaces',
- '--default-character-set=utf8mb4',
- '--net-buffer-length=523264',
- '--max-allowed-packet=256M',
- ...extraParams,
- dbConfig.database,
- ],
- {
- stdio: ['ignore', 'pipe', 'ignore'],
- },
+ const params = [
+ '-h',
+ dbConfig.host,
+ '-u',
+ dbConfig.user,
+ `-p${dbConfig.password}`,
+ ];
+ if (dbConfig.port) {
+ params.push('-P', String(dbConfig.port));
+ }
+ params.push(
+ '--single-transaction',
+ '--no-tablespaces',
+ '--default-character-set=utf8mb4',
+ '--net-buffer-length=523264',
+ '--max-allowed-packet=256M',
+ ...extraParams,
+ dbConfig.database,
);
+ const mysqlDump = childProcess.spawn('mysqldump', params, {
+ stdio: ['ignore', 'pipe', 'ignore'],
+ });
const extraParamsString = extraParams.join(' ');
return new Promise((resolve, reject) => {
mysqlDump.on('error', (e: Error) => {

File Metadata

Mime Type
text/plain
Expires
Sat, Sep 21, 1:29 AM (21 h, 44 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2154820
Default Alt Text
D13134.id43561.diff (1 KB)

Event Timeline