Page MenuHomePhabricator
Files F2840471

D13362.id44290.diff
No OneTemporary
Actions

D13362.id44290.diff
View Options

diff --git a/lib/shared/reaction-utils.js b/lib/shared/reaction-utils.js
--- a/lib/shared/reaction-utils.js
+++ b/lib/shared/reaction-utils.js
@@ -14,6 +14,7 @@
} from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from '../types/thread-permission-types.js';
+import { threadTypeIsThick } from '../types/thread-types-enum.js';
import { useSelector } from '../utils/redux-utils.js';
function useViewerAlreadySelectedMessageReactions(
@@ -92,8 +93,9 @@
}
if (
- !targetMessageInfo.id ||
- threadInfo.sourceMessageID === targetMessageInfo.id
+ (!targetMessageInfo.id && !threadTypeIsThick(threadInfo.type)) ||
+ (threadInfo.sourceMessageID &&
+ threadInfo.sourceMessageID === targetMessageInfo.id)
) {
return false;
}
diff --git a/lib/shared/sidebar-utils.js b/lib/shared/sidebar-utils.js
--- a/lib/shared/sidebar-utils.js
+++ b/lib/shared/sidebar-utils.js
@@ -210,8 +210,9 @@
}
if (
- !messageInfo.id ||
- threadInfo.sourceMessageID === messageInfo.id ||
+ (!messageInfo.id && !threadTypeIsThick(threadInfo.type)) ||
+ (threadInfo.sourceMessageID &&
+ threadInfo.sourceMessageID === messageInfo.id) ||
isInvalidSidebarSource(messageInfo)
) {
return false;

File Metadata

Mime Type
text/plain
Expires
Mon, Sep 30, 5:55 AM (10 h, 32 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2181886
Default Alt Text
D13362.id44290.diff (1 KB)

Event Timeline