Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F2905655
D3616.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D3616.diff
View Options
diff --git a/web/modals/modal.react.js b/web/modals/modal.react.js
--- a/web/modals/modal.react.js
+++ b/web/modals/modal.react.js
@@ -12,6 +12,7 @@
+name: React.Node,
+icon?: Icon,
+onClose: () => void,
+ +withCloseButton?: boolean,
+children?: React.Node,
+size?: ModalSize,
+fixedHeight?: boolean,
@@ -29,7 +30,15 @@
}
render(): React.Node {
- const { size, children, onClose, fixedHeight, name, icon } = this.props;
+ const {
+ size,
+ children,
+ onClose,
+ fixedHeight,
+ name,
+ icon,
+ withCloseButton = false,
+ } = this.props;
const overlayClasses = classNames(
css['modal-overlay'],
@@ -49,6 +58,15 @@
headerIcon = <SWMansionIcon size={24} icon={icon} />;
}
+ let cornerCloseButton;
+ if (withCloseButton) {
+ cornerCloseButton = (
+ <span className={css['modal-close']} onClick={onClose}>
+ <SWMansionIcon size={24} icon="cross" />
+ </span>
+ );
+ }
+
return (
<div
className={overlayClasses}
@@ -60,9 +78,7 @@
<div className={modalContainerClasses}>
<div className={modalClasses}>
<div className={css['modal-header']}>
- <span className={css['modal-close']} onClick={onClose}>
- ×
- </span>
+ {cornerCloseButton}
<h2>
{headerIcon}
{name}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Oct 7, 7:22 AM (21 h, 55 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2252752
Default Alt Text
D3616.diff (1 KB)
Attached To
Mode
D3616: [web] [fix] [ENG-716] use cross icon in modal
Attached
Detach File
Event Timeline
Log In to Comment