Page MenuHomePhabricator
Files F2911672

D9104.id30932.diff
No OneTemporary
Actions

D9104.id30932.diff
View Options

diff --git a/web/chat/chat-thread-list-see-more-sidebars.react.js b/web/chat/chat-thread-list-see-more-sidebars.react.js
--- a/web/chat/chat-thread-list-see-more-sidebars.react.js
+++ b/web/chat/chat-thread-list-see-more-sidebars.react.js
@@ -31,7 +31,7 @@
);
return (
<a className={classNames(css.thread, css.sidebar)} onClick={onClick}>
- <a className={css.threadButton}>
+ <div className={css.threadButton}>
<div
className={classNames({
[css.sidebarTitle]: true,
@@ -42,7 +42,7 @@
<IoIosMore size="22px" />
<div className={css.seeMoreText}>See more...</div>
</div>
- </a>
+ </div>
</a>
);
}
diff --git a/web/chat/chat-thread-list-sidebar.react.js b/web/chat/chat-thread-list-sidebar.react.js
--- a/web/chat/chat-thread-list-sidebar.react.js
+++ b/web/chat/chat-thread-list-sidebar.react.js
@@ -8,10 +8,7 @@
import ChatThreadListItemMenu from './chat-thread-list-item-menu.react.js';
import css from './chat-thread-list.css';
import SidebarItem from './sidebar-item.react.js';
-import {
- useOnClickThread,
- useThreadIsActive,
-} from '../selectors/thread-selectors.js';
+import { useThreadIsActive } from '../selectors/thread-selectors.js';
type Props = {
+sidebarInfo: SidebarInfo,
@@ -26,18 +23,16 @@
} = threadInfo;
const active = useThreadIsActive(threadID);
- const onClick = useOnClickThread(threadInfo);
let unreadDot;
if (unread) {
unreadDot = <div className={css.unreadDot} />;
}
return (
- <a
+ <div
className={classNames(css.threadListSidebar, css.sidebar, {
[css.activeThread]: active,
})}
- onClick={onClick}
>
<div className={css.dotContainer}>{unreadDot}</div>
<SidebarItem sidebarInfo={sidebarInfo} extendArrow={isSubsequentItem} />
@@ -46,7 +41,7 @@
mostRecentNonLocalMessage={mostRecentNonLocalMessage}
renderStyle="thread"
/>
- </a>
+ </div>
);
}
diff --git a/web/chat/chat-thread-list.css b/web/chat/chat-thread-list.css
--- a/web/chat/chat-thread-list.css
+++ b/web/chat/chat-thread-list.css
@@ -2,6 +2,13 @@
display: flex;
flex-direction: row;
}
+
+.sidebarItem {
+ display: flex;
+ flex-direction: row;
+ width: 100%;
+}
+
.threadListSidebar {
display: flex;
flex-direction: row;
diff --git a/web/chat/sidebar-item.react.js b/web/chat/sidebar-item.react.js
--- a/web/chat/sidebar-item.react.js
+++ b/web/chat/sidebar-item.react.js
@@ -41,15 +41,15 @@
}
const { uiName } = useResolvedThreadInfo(threadInfo);
return (
- <>
+ <a className={css.sidebarItem} onClick={onClick}>
{arrow}
<div className={css.spacer} />
- <a className={css.threadButtonSidebar} onClick={onClick}>
+ <div className={css.threadButtonSidebar}>
<div className={css.threadRow}>
<div className={unreadCls}>{uiName}</div>
</div>
- </a>
- </>
+ </div>
+ </a>
);
}

File Metadata

Mime Type
text/plain
Expires
Tue, Oct 8, 12:19 AM (21 h, 52 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2256373
Default Alt Text
D9104.id30932.diff (2 KB)

Event Timeline