Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F2982392
D13709.id45198.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D13709.id45198.diff
View Options
diff --git a/native/chat/multimedia-message.react.js b/native/chat/multimedia-message.react.js
--- a/native/chat/multimedia-message.react.js
+++ b/native/chat/multimedia-message.react.js
@@ -10,6 +10,7 @@
import { View } from 'react-native';
import { messageKey } from 'lib/shared/message-utils.js';
+import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';
import { useCanCreateSidebarFromMessage } from 'lib/shared/sidebar-utils.js';
import type { MediaInfo } from 'lib/types/media-types.js';
@@ -51,6 +52,7 @@
+overlayContext: ?OverlayContextType,
+chatContext: ?ChatContextType,
+canCreateSidebarFromMessage: boolean,
+ +canCreateReactionFromMessage: boolean,
};
type State = {
+clickable: boolean,
@@ -115,7 +117,10 @@
onLongPress = () => {
const visibleEntryIDs = this.visibleEntryIDs();
- if (visibleEntryIDs.length === 0) {
+ if (
+ visibleEntryIDs.length === 0 &&
+ !this.props.canCreateReactionFromMessage
+ ) {
return;
}
@@ -202,6 +207,7 @@
chatContext,
canCreateSidebarFromMessage,
canTogglePins,
+ canCreateReactionFromMessage,
...viewProps
} = this.props;
return (
@@ -238,7 +244,10 @@
props.item.threadInfo,
props.item.messageInfo,
);
-
+ const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
+ props.item.threadInfo,
+ props.item.messageInfo,
+ );
return (
<MultimediaMessage
{...props}
@@ -247,6 +256,7 @@
overlayContext={overlayContext}
chatContext={chatContext}
canCreateSidebarFromMessage={canCreateSidebarFromMessage}
+ canCreateReactionFromMessage={canCreateReactionFromMessage}
/>
);
});
diff --git a/native/chat/robotext-message.react.js b/native/chat/robotext-message.react.js
--- a/native/chat/robotext-message.react.js
+++ b/native/chat/robotext-message.react.js
@@ -9,6 +9,7 @@
chatMessageItemHasEngagement,
chatMessageItemEngagementTargetMessageInfo,
} from 'lib/shared/chat-message-item-utils.js';
+import { useCanCreateReactionFromMessage } from 'lib/shared/reaction-utils.js';
import { useCanCreateSidebarFromMessage } from 'lib/shared/sidebar-utils.js';
import { inlineEngagementCenterStyle } from './chat-constants.js';
@@ -101,6 +102,10 @@
item.threadInfo,
engagementTargetMessageInfo,
);
+ const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
+ item.threadInfo,
+ engagementTargetMessageInfo,
+ );
const visibleEntryIDs = React.useMemo(() => {
const result = [];
@@ -178,7 +183,7 @@
return;
}
- if (visibleEntryIDs.length === 0) {
+ if (visibleEntryIDs.length === 0 && !canCreateReactionFromMessage) {
return;
}
@@ -203,6 +208,7 @@
viewRef,
visibleEntryIDs,
openRobotextTooltipModal,
+ canCreateReactionFromMessage,
]);
const onLayout = React.useCallback(() => {}, []);
diff --git a/native/chat/text-message.react.js b/native/chat/text-message.react.js
--- a/native/chat/text-message.react.js
+++ b/native/chat/text-message.react.js
@@ -178,9 +178,6 @@
onPress = () => {
const visibleEntryIDs = this.visibleEntryIDs();
- if (visibleEntryIDs.length === 0) {
- return;
- }
const {
message,
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Oct 17, 3:23 AM (22 h, 4 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2297824
Default Alt Text
D13709.id45198.diff (3 KB)
Attached To
Mode
D13709: [native] Fix reacting to robotext when sidebar is disabled
Attached
Detach File
Event Timeline
Log In to Comment