Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F2988222
D13663.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D13663.diff
View Options
diff --git a/lib/shared/dm-ops/process-dm-ops.js b/lib/shared/dm-ops/process-dm-ops.js
--- a/lib/shared/dm-ops/process-dm-ops.js
+++ b/lib/shared/dm-ops/process-dm-ops.js
@@ -20,6 +20,7 @@
usePeerToPeerCommunication,
type ProcessOutboundP2PMessagesResult,
} from '../../tunnelbroker/peer-to-peer-context.js';
+import { useConfirmPeerToPeerMessage } from '../../tunnelbroker/use-confirm-peer-to-peer-message.js';
import {
processDMOpsActionType,
queueDMOpsActionType,
@@ -39,6 +40,7 @@
const dispatchWithMetadata = useDispatchWithMetadata();
const processBlobHolders = useProcessBlobHolders();
const createMessagesToPeersFromDMOp = useCreateMessagesToPeersFromDMOp();
+ const confirmPeerToPeerMessage = useConfirmPeerToPeerMessage();
const dispatch = useDispatch();
@@ -121,6 +123,7 @@
if (!dmOpSpecs[dmOp.type].operationValidator.is(dmOp)) {
console.log(`Ignoring ${dmOp.type} operation because it is invalid`);
+ await confirmPeerToPeerMessage(dispatchMetadata);
return;
}
@@ -131,6 +134,7 @@
if (!processingCheckResult.isProcessingPossible) {
if (processingCheckResult.reason.type === 'invalid') {
+ await confirmPeerToPeerMessage(dispatchMetadata);
return;
}
let condition;
@@ -167,6 +171,7 @@
},
dispatchMetadata,
);
+ await confirmPeerToPeerMessage(dispatchMetadata);
return;
}
@@ -236,6 +241,7 @@
dispatchWithMetadata,
createMessagesToPeersFromDMOp,
dispatch,
+ confirmPeerToPeerMessage,
],
);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Oct 17, 4:27 PM (21 h, 37 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2311780
Default Alt Text
D13663.diff (1 KB)
Attached To
Mode
D13663: [lib] send confirmation for ignored DM ops
Attached
Detach File
Event Timeline
Log In to Comment