Page MenuHomePhabricator
Files F3002646

D9044.id30618.diff
No OneTemporary
Actions

D9044.id30618.diff
View Options

diff --git a/lib/actions/report-actions.js b/lib/actions/report-actions.js
--- a/lib/actions/report-actions.js
+++ b/lib/actions/report-actions.js
@@ -11,33 +11,29 @@
success: 'SEND_REPORT_SUCCESS',
failed: 'SEND_REPORT_FAILED',
});
-const sendReport =
- (): ((
- request: ClientReportCreationRequest,
- ) => Promise<ReportCreationResponse>) =>
- async request => {
- const {
- reportIDs: [id],
- } = await callSendReports([request]);
+const sendReport: (
+ request: ClientReportCreationRequest,
+) => Promise<ReportCreationResponse> = async request => {
+ const {
+ reportIDs: [id],
+ } = await callSendReports([request]);
- if (!id) {
- throw new Error('Server did not return report ID');
- }
- return { id };
- };
+ if (!id) {
+ throw new Error('Server did not return report ID');
+ }
+ return { id };
+};
const sendReportsActionTypes = Object.freeze({
started: 'SEND_REPORTS_STARTED',
success: 'SEND_REPORTS_SUCCESS',
failed: 'SEND_REPORTS_FAILED',
});
-const sendReports =
- (): ((
- reports: $ReadOnlyArray<ClientReportCreationRequest>,
- ) => Promise<void>) =>
- async clientReports => {
- await callSendReports(clientReports);
- };
+const sendReports: (
+ clientReports: $ReadOnlyArray<ClientReportCreationRequest>,
+) => Promise<void> = async clientReports => {
+ await callSendReports(clientReports);
+};
const queueReportsActionType = 'QUEUE_REPORTS';
diff --git a/lib/socket/report-handler.react.js b/lib/socket/report-handler.react.js
--- a/lib/socket/report-handler.react.js
+++ b/lib/socket/report-handler.react.js
@@ -14,7 +14,6 @@
import {
type DispatchActionPromise,
useDispatchActionPromise,
- useServerCall,
} from '../utils/action-utils.js';
import { useSelector } from '../utils/redux-utils.js';
@@ -81,14 +80,13 @@
const ConnectedReportHandler: React.ComponentType<BaseProps> =
React.memo<BaseProps>(function ConnectedReportHandler(props) {
const queuedReports = useSelector(queuedReportsSelector);
- const callSendReports = useServerCall(sendReports);
const dispatchActionPromise = useDispatchActionPromise();
return (
<ReportHandler
{...props}
queuedReports={queuedReports}
- sendReports={callSendReports}
+ sendReports={sendReports}
dispatchActionPromise={dispatchActionPromise}
/>
);
diff --git a/native/crash.react.js b/native/crash.react.js
--- a/native/crash.react.js
+++ b/native/crash.react.js
@@ -281,7 +281,6 @@
const preRequestUserState = useSelector(preRequestUserStateSelector);
const dispatchActionPromise = useDispatchActionPromise();
- const callSendReport = useServerCall(sendReport);
const callLogOut = useServerCall(logOut);
const crashReportingEnabled = useIsReportEnabled('crashReports');
return (
@@ -289,7 +288,7 @@
{...props}
preRequestUserState={preRequestUserState}
dispatchActionPromise={dispatchActionPromise}
- sendReport={callSendReport}
+ sendReport={sendReport}
logOut={callLogOut}
crashReportingEnabled={crashReportingEnabled}
/>

File Metadata

Mime Type
text/plain
Expires
Sat, Oct 19, 8:24 AM (22 h, 4 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2322063
Default Alt Text
D9044.id30618.diff (3 KB)

Event Timeline