Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3011582
D13301.id44070.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D13301.id44070.diff
View Options
diff --git a/keyserver/src/fetchers/community-fetchers.js b/keyserver/src/fetchers/community-fetchers.js
--- a/keyserver/src/fetchers/community-fetchers.js
+++ b/keyserver/src/fetchers/community-fetchers.js
@@ -44,12 +44,12 @@
return communityInfos;
}
-async function checkIfCommunityHasFarcasterChannelTag(
+async function fetchCommunityFarcasterChannelTag(
viewer: Viewer,
communityID: string,
-): Promise<boolean> {
+): Promise<?string> {
if (!viewer.loggedIn) {
- return false;
+ return null;
}
const query = SQL`
@@ -62,7 +62,7 @@
const communityInfo = result[0];
- return !!communityInfo?.farcasterChannelID;
+ return communityInfo?.farcasterChannelID;
}
-export { fetchCommunityInfos, checkIfCommunityHasFarcasterChannelTag };
+export { fetchCommunityInfos, fetchCommunityFarcasterChannelTag };
diff --git a/keyserver/src/updaters/thread-updaters.js b/keyserver/src/updaters/thread-updaters.js
--- a/keyserver/src/updaters/thread-updaters.js
+++ b/keyserver/src/updaters/thread-updaters.js
@@ -45,7 +45,7 @@
import createMessages from '../creators/message-creator.js';
import { createUpdates } from '../creators/update-creator.js';
import { dbQuery, SQL } from '../database/database.js';
-import { checkIfCommunityHasFarcasterChannelTag } from '../fetchers/community-fetchers.js';
+import { fetchCommunityFarcasterChannelTag } from '../fetchers/community-fetchers.js';
import { checkIfInviteLinkIsValid } from '../fetchers/link-fetchers.js';
import { fetchMessageInfoByID } from '../fetchers/message-fetchers.js';
import {
@@ -840,15 +840,14 @@
);
const communityFarcasterChannelTagPromise =
- checkIfCommunityHasFarcasterChannelTag(viewer, request.threadID);
+ fetchCommunityFarcasterChannelTag(viewer, request.threadID);
- const [threadPermission, hasCommunityFarcasterChannelTag] =
- await Promise.all([
- threadPermissionPromise,
- communityFarcasterChannelTagPromise,
- ]);
+ const [threadPermission, communityFarcasterChannelTag] = await Promise.all([
+ threadPermissionPromise,
+ communityFarcasterChannelTagPromise,
+ ]);
- return threadPermission || hasCommunityFarcasterChannelTag;
+ return threadPermission || !!communityFarcasterChannelTag;
})();
const [isMember, hasPermission] = await Promise.all([
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Oct 20, 1:39 AM (20 h, 7 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2326828
Default Alt Text
D13301.id44070.diff (2 KB)
Attached To
Mode
D13301: [keyserver] modify community fetcher to return channel tag
Attached
Detach File
Event Timeline
Log In to Comment