Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3048494
D9222.id31226.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D9222.id31226.diff
View Options
diff --git a/lib/reducers/message-reducer.js b/lib/reducers/message-reducer.js
--- a/lib/reducers/message-reducer.js
+++ b/lib/reducers/message-reducer.js
@@ -10,7 +10,6 @@
import _mapValues from 'lodash/fp/mapValues.js';
import _omit from 'lodash/fp/omit.js';
import _omitBy from 'lodash/fp/omitBy.js';
-import _pick from 'lodash/fp/pick.js';
import _pickBy from 'lodash/fp/pickBy.js';
import _uniq from 'lodash/fp/uniq.js';
@@ -674,20 +673,19 @@
} = reassignMessagesToRealizedThreads(messageStore, threadInfos);
messageStoreOperations.push(...reassignMessagesOps);
const watchedIDs = [...threadWatcher.getWatchedIDs(), ...reassignedThreadIDs];
- const watchedThreadInfos = _pickBy((threadInfo: RawThreadInfo) =>
- isThreadWatched(threadInfo.id, threadInfo, watchedIDs),
- )(threadInfos);
-
- const filteredThreads = _pick(Object.keys(watchedThreadInfos))(
- reassignedMessageStore.threads,
- );
const messageIDsToRemove = [];
const threadsToRemoveMessagesFrom = [];
+ const filteredThreads = {};
for (const threadID in reassignedMessageStore.threads) {
- if (watchedThreadInfos[threadID]) {
+ const threadMessageInfo = reassignedMessageStore.threads[threadID];
+ const threadInfo = threadInfos[threadID];
+
+ if (isThreadWatched(threadID, threadInfo, watchedIDs)) {
+ filteredThreads[threadID] = threadMessageInfo;
continue;
}
+
threadsToRemoveMessagesFrom.push(threadID);
for (const id of reassignedMessageStore.threads[threadID].messageIDs) {
messageIDsToRemove.push(id);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Oct 23, 11:22 PM (21 h, 58 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2354773
Default Alt Text
D9222.id31226.diff (1 KB)
Attached To
Mode
D9222: [lib] Don't drop messages in MessageStore that don't have a corresponding ThreadInfo
Attached
Detach File
Event Timeline
Log In to Comment