Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3098169
D13679.id45038.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
5 KB
Referenced Files
None
Subscribers
None
D13679.id45038.diff
View Options
diff --git a/native/chat/composed-message.react.js b/native/chat/composed-message.react.js
--- a/native/chat/composed-message.react.js
+++ b/native/chat/composed-message.react.js
@@ -33,7 +33,7 @@
import CommIcon from '../components/comm-icon.react.js';
import { InputStateContext } from '../input/input-state.js';
import { useColors } from '../themes/colors.js';
-import type { ChatMessageInfoItemWithHeight } from '../types/chat-types.js';
+import type { ChatComposedMessageInfoItemWithHeight } from '../types/chat-types.js';
import {
type AnimatedStyleObj,
type ViewStyle,
@@ -44,7 +44,7 @@
type SwipeOptions = 'reply' | 'sidebar' | 'both' | 'none';
type Props = {
...React.ElementConfig<typeof View>,
- +item: ChatMessageInfoItemWithHeight,
+ +item: ChatComposedMessageInfoItemWithHeight,
+sendFailed: boolean,
+focused: boolean,
+swipeOptions: SwipeOptions,
diff --git a/native/chat/failed-send.react.js b/native/chat/failed-send.react.js
--- a/native/chat/failed-send.react.js
+++ b/native/chat/failed-send.react.js
@@ -19,7 +19,7 @@
import { type InputState, InputStateContext } from '../input/input-state.js';
import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js';
-import type { ChatMessageInfoItemWithHeight } from '../types/chat-types.js';
+import type { ChatComposedMessageInfoItemWithHeight } from '../types/chat-types.js';
const failedSendHeight = 22;
@@ -41,7 +41,7 @@
};
type BaseProps = {
- +item: ChatMessageInfoItemWithHeight,
+ +item: ChatComposedMessageInfoItemWithHeight,
};
type Props = {
...BaseProps,
diff --git a/native/chat/inline-engagement.react.js b/native/chat/inline-engagement.react.js
--- a/native/chat/inline-engagement.react.js
+++ b/native/chat/inline-engagement.react.js
@@ -27,7 +27,7 @@
import GestureTouchableOpacity from '../components/gesture-touchable-opacity.react.js';
import { MessageReactionsModalRouteName } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js';
-import type { ChatMessageInfoItemWithHeight } from '../types/chat-types.js';
+import type { ChatComposedMessageInfoItemWithHeight } from '../types/chat-types.js';
function dummyNodeForInlineEngagementHeightMeasurement(
sidebarInfo: ?ThreadInfo,
@@ -461,7 +461,7 @@
};
type TooltipInlineEngagementProps = {
- +item: ChatMessageInfoItemWithHeight,
+ +item: ChatComposedMessageInfoItemWithHeight,
+isOpeningSidebar: boolean,
+progress: Animated.Node,
+windowWidth: number,
diff --git a/native/chat/message-header.react.js b/native/chat/message-header.react.js
--- a/native/chat/message-header.react.js
+++ b/native/chat/message-header.react.js
@@ -12,11 +12,11 @@
import SingleLine from '../components/single-line.react.js';
import { MessageListRouteName } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js';
-import type { ChatMessageInfoItemWithHeight } from '../types/chat-types.js';
+import type { ChatComposedMessageInfoItemWithHeight } from '../types/chat-types.js';
import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
type Props = {
- +item: ChatMessageInfoItemWithHeight,
+ +item: ChatComposedMessageInfoItemWithHeight,
+focused: boolean,
+display: DisplayType,
};
diff --git a/native/chat/message-tooltip-button-avatar.react.js b/native/chat/message-tooltip-button-avatar.react.js
--- a/native/chat/message-tooltip-button-avatar.react.js
+++ b/native/chat/message-tooltip-button-avatar.react.js
@@ -5,10 +5,10 @@
import { avatarOffset } from './chat-constants.js';
import UserAvatar from '../avatars/user-avatar.react.js';
-import type { ChatMessageInfoItemWithHeight } from '../types/chat-types.js';
+import type { ChatComposedMessageInfoItemWithHeight } from '../types/chat-types.js';
type Props = {
- +item: ChatMessageInfoItemWithHeight,
+ +item: ChatComposedMessageInfoItemWithHeight,
};
function MessageTooltipButtonAvatar(props: Props): React.Node {
diff --git a/native/chat/rounded-corners.js b/native/chat/rounded-corners.js
--- a/native/chat/rounded-corners.js
+++ b/native/chat/rounded-corners.js
@@ -2,7 +2,7 @@
import type { Corners } from 'lib/types/media-types.js';
-import type { ChatMessageInfoItemWithHeight } from '../types/chat-types.js';
+import type { ChatComposedMessageInfoItemWithHeight } from '../types/chat-types.js';
type FilteredCorners = {
+bottomLeft: void | boolean,
@@ -12,7 +12,7 @@
};
function filterCorners(
corners: Corners,
- item: ChatMessageInfoItemWithHeight,
+ item: ChatComposedMessageInfoItemWithHeight,
): FilteredCorners {
const { startsCluster, endsCluster } = item;
const { isViewer } = item.messageInfo.creator;
diff --git a/native/chat/toggle-pin-modal.react.js b/native/chat/toggle-pin-modal.react.js
--- a/native/chat/toggle-pin-modal.react.js
+++ b/native/chat/toggle-pin-modal.react.js
@@ -18,10 +18,10 @@
import type { AppNavigationProp } from '../navigation/app-navigator.react.js';
import type { NavigationRoute } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js';
-import type { ChatMessageInfoItemWithHeight } from '../types/chat-types';
+import type { ChatComposedMessageInfoItemWithHeight } from '../types/chat-types.js';
export type TogglePinModalParams = {
- +item: ChatMessageInfoItemWithHeight,
+ +item: ChatComposedMessageInfoItemWithHeight,
+threadInfo: ThreadInfo,
};
diff --git a/native/types/chat-types.js b/native/types/chat-types.js
--- a/native/types/chat-types.js
+++ b/native/types/chat-types.js
@@ -68,6 +68,10 @@
+inlineEngagementHeight: ?number,
};
+export type ChatComposedMessageInfoItemWithHeight =
+ | ChatTextMessageInfoItemWithHeight
+ | ChatMultimediaMessageInfoItem;
+
export type ChatMessageInfoItemWithHeight =
| ChatRobotextMessageInfoItemWithHeight
| ChatTextMessageInfoItemWithHeight
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Oct 30, 5:24 PM (6 h, 55 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2388688
Default Alt Text
D13679.id45038.diff (5 KB)
Attached To
Mode
D13679: [native] Narrow ChatMessageInfoItemWithHeight to ChatComposedMessageInfoItemWithHeight where appropriate
Attached
Detach File
Event Timeline
Log In to Comment