Page MenuHomePhabricator
Files F3102034

D13676.diff
No OneTemporary
Actions

D13676.diff
View Options

diff --git a/native/chat/inline-engagement.react.js b/native/chat/inline-engagement.react.js
--- a/native/chat/inline-engagement.react.js
+++ b/native/chat/inline-engagement.react.js
@@ -17,7 +17,6 @@
import {
avatarOffset,
composedMessageStyle,
- inlineEngagementCenterStyle,
inlineEngagementLabelStyle,
inlineEngagementRightStyle,
inlineEngagementStyle,
@@ -503,15 +502,10 @@
composedMessageStyle.marginRight,
top: inlineEngagementStyle.marginTop + inlineEngagementStyle.topOffset,
};
- } else if (positioning === 'center') {
- return {
- alignSelf: 'center',
- top: inlineEngagementCenterStyle.topOffset,
- };
}
invariant(
false,
- `${positioning} is not a valid positioning value for InlineEngagement`,
+ `${positioning} is not a valid positioning value for TooltipInlineEngagement`,
);
}, [positioning]);
const inlineEngagementContainer = React.useMemo(() => {
diff --git a/native/chat/robotext-message-tooltip-button.react.js b/native/chat/robotext-message-tooltip-button.react.js
--- a/native/chat/robotext-message-tooltip-button.react.js
+++ b/native/chat/robotext-message-tooltip-button.react.js
@@ -8,7 +8,6 @@
useCanCreateReactionFromMessage,
} from 'lib/shared/reaction-utils.js';
-import { TooltipInlineEngagement } from './inline-engagement.react.js';
import { InnerRobotextMessage } from './inner-robotext-message.react.js';
import { useSendReaction } from './reaction-message-utils.js';
import ReactionSelectionPopover from './reaction-selection-popover.react.js';
@@ -28,10 +27,10 @@
+navigation: AppNavigationProp<'RobotextMessageTooltipModal'>,
+route: TooltipRoute<'RobotextMessageTooltipModal'>,
+progress: Node,
- +isOpeningSidebar: boolean,
+ ...
};
function RobotextMessageTooltipButton(props: Props): React.Node {
- const { navigation, route, progress, isOpeningSidebar } = props;
+ const { navigation, route, progress } = props;
const windowWidth = useSelector(state => state.dimensions.width);
@@ -67,22 +66,6 @@
};
}, [initialCoordinates.height, initialCoordinates.x, progress, windowWidth]);
- const inlineEngagement = React.useMemo(() => {
- if (!item.threadCreatedFromMessage) {
- return null;
- }
- return (
- <TooltipInlineEngagement
- item={item}
- positioning="center"
- isOpeningSidebar={isOpeningSidebar}
- progress={progress}
- windowWidth={windowWidth}
- initialCoordinates={initialCoordinates}
- />
- );
- }, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]);
-
const { messageInfo, threadInfo, reactions } = item;
const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
@@ -144,7 +127,6 @@
</Animated.View>
{reactionSelectionPopover}
<InnerRobotextMessage item={item} onPress={navigation.goBackOnce} />
- {inlineEngagement}
</Animated.View>
<EmojiKeyboard
onEmojiSelected={onEmojiSelected}

File Metadata

Mime Type
text/plain
Expires
Thu, Oct 31, 10:21 AM (21 h, 59 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2391563
Default Alt Text
D13676.diff (2 KB)

Event Timeline