Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3178912
D3930.id12281.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D3930.id12281.diff
View Options
diff --git a/web/modals/threads/thread-settings-modal.css b/web/modals/threads/thread-settings-modal.css
--- a/web/modals/threads/thread-settings-modal.css
+++ b/web/modals/threads/thread-settings-modal.css
@@ -1,8 +1,4 @@
div.modal_body {
- padding: 20px;
- background-color: var(--modal-bg);
- border-radius: 16px;
- flex: 1;
display: flex;
flex-direction: column;
}
diff --git a/web/modals/threads/thread-settings-modal.react.js b/web/modals/threads/thread-settings-modal.react.js
--- a/web/modals/threads/thread-settings-modal.react.js
+++ b/web/modals/threads/thread-settings-modal.react.js
@@ -111,14 +111,16 @@
const tabs = [
<Tabs.Item id="general" header="General" key="general">
- <ThreadSettingsGeneralTab
- inputDisabled={inputDisabled}
- threadInfo={threadInfo}
- threadNamePlaceholder={namePlaceholder}
- queuedChanges={queuedChanges}
- setQueuedChanges={setQueuedChanges}
- setErrorMessage={setErrorMessage}
- />
+ <div className={css.tab_body}>
+ <ThreadSettingsGeneralTab
+ inputDisabled={inputDisabled}
+ threadInfo={threadInfo}
+ threadNamePlaceholder={namePlaceholder}
+ queuedChanges={queuedChanges}
+ setQueuedChanges={setQueuedChanges}
+ setErrorMessage={setErrorMessage}
+ />
+ </div>
</Tabs.Item>,
];
@@ -134,13 +136,15 @@
if (canSeePrivacyTab) {
tabs.push(
<Tabs.Item id="privacy" header="Privacy" key="privacy">
- <ThreadSettingsPrivacyTab
- inputDisabled={inputDisabled}
- threadInfo={threadInfo}
- queuedChanges={queuedChanges}
- setQueuedChanges={setQueuedChanges}
- setErrorMessage={setErrorMessage}
- />
+ <div className={css.tab_body}>
+ <ThreadSettingsPrivacyTab
+ inputDisabled={inputDisabled}
+ threadInfo={threadInfo}
+ queuedChanges={queuedChanges}
+ setQueuedChanges={setQueuedChanges}
+ setErrorMessage={setErrorMessage}
+ />
+ </div>
</Tabs.Item>,
);
}
@@ -149,11 +153,13 @@
if (canDeleteThread) {
tabs.push(
<Tabs.Item id="delete" header="Delete" key="delete">
- <ThreadSettingsDeleteTab
- inputDisabled={inputDisabled}
- threadInfo={threadInfo}
- setErrorMessage={setErrorMessage}
- />
+ <div className={css.tab_body}>
+ <ThreadSettingsDeleteTab
+ inputDisabled={inputDisabled}
+ threadInfo={threadInfo}
+ setErrorMessage={setErrorMessage}
+ />
+ </div>
</Tabs.Item>,
);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 9, 2:38 AM (20 h, 53 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2447690
Default Alt Text
D3930.id12281.diff (2 KB)
Attached To
Mode
D3930: [web] Move padding from `modal_body` to `tab_body` in `ThreadSettingsModal`
Attached
Detach File
Event Timeline
Log In to Comment