Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F32145372
D15397.1765031657.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Size
2 KB
Referenced Files
None
Subscribers
None
D15397.1765031657.diff
View Options
diff --git a/lib/shared/id-utils.js b/lib/shared/id-utils.js
--- a/lib/shared/id-utils.js
+++ b/lib/shared/id-utils.js
@@ -163,6 +163,10 @@
return userID.replace(farcasterUserIDPrefix, '');
}
+function isFarcasterUserID(userID: string): boolean {
+ return userID.startsWith(farcasterUserIDPrefix);
+}
+
function farcasterPersonalConversationID(
user1FID: number | string,
user2FID: number | string,
@@ -192,4 +196,5 @@
extractFIDFromUserID,
farcasterPersonalConversationID,
getFIDFromUserID,
+ isFarcasterUserID,
};
diff --git a/lib/shared/relationship-utils.js b/lib/shared/relationship-utils.js
--- a/lib/shared/relationship-utils.js
+++ b/lib/shared/relationship-utils.js
@@ -2,6 +2,7 @@
import invariant from 'invariant';
+import { isFarcasterUserID } from './id-utils.js';
import {
type RelationshipButton,
type UserRelationshipStatus,
@@ -27,8 +28,11 @@
}
function getAvailableRelationshipButtons(
- userInfo: UserInfo,
+ userInfo: ?UserInfo,
): RelationshipButton[] {
+ if (!userInfo || isFarcasterUserID(userInfo.id)) {
+ return [];
+ }
const relationship = userInfo.relationshipStatus;
if (relationship === userRelationshipStatus.FRIEND) {
diff --git a/native/chat/settings/thread-settings-edit-relationship.react.js b/native/chat/settings/thread-settings-edit-relationship.react.js
--- a/native/chat/settings/thread-settings-edit-relationship.react.js
+++ b/native/chat/settings/thread-settings-edit-relationship.react.js
@@ -12,6 +12,7 @@
getRelationshipDispatchAction,
} from 'lib/shared/relationship-utils.js';
import { getSingleOtherUser } from 'lib/shared/thread-utils.js';
+import { stringForUserExplicit } from 'lib/shared/user-utils.js';
import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import {
type TraditionalRelationshipAction,
@@ -88,8 +89,7 @@
const { panelIosHighlightUnderlay } = colors;
const styles = useStyles(unboundStyles);
- const otherUserInfoUsername = otherUserInfo.username;
- invariant(otherUserInfoUsername, 'Other user username should be specified');
+ const otherUserInfoUsername = stringForUserExplicit(otherUserInfo);
const relationshipButtonText = React.useMemo(
() =>
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 6, 2:34 PM (15 h, 15 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5838621
Default Alt Text
D15397.1765031657.diff (2 KB)
Attached To
Mode
D15397: [lib] Fix handling 1:1 conversations
Attached
Detach File
Event Timeline
Log In to Comment