Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F32156164
D15459.1765035807.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D15459.1765035807.diff
View Options
diff --git a/lib/shared/farcaster/farcaster-hooks.js b/lib/shared/farcaster/farcaster-hooks.js
--- a/lib/shared/farcaster/farcaster-hooks.js
+++ b/lib/shared/farcaster/farcaster-hooks.js
@@ -721,11 +721,11 @@
}> => {
const result: Array<RawMessageInfo> = [];
const userIDs: Array<string> = [];
+ const messageIDs = new Set<string>();
let batchNumber = 0;
try {
let totalMessagesFetched = 0;
- let lastSeenMessageID: ?string = null;
do {
batchNumber++;
@@ -765,26 +765,25 @@
}),
new Set([logTypes.FARCASTER]),
);
+ break;
}
- const lastMessageID =
- farcasterMessages.length > 0
- ? farcasterMessages[farcasterMessages.length - 1].messageId
- : null;
+ const prevMessageCount = messageIDs.size;
+ messageIDs.add(
+ ...farcasterMessages.map(message => message.messageId),
+ );
- if (lastMessageID === lastSeenMessageID) {
+ if (prevMessageCount === messageIDs.size) {
addLog(
'Farcaster: Duplicate message batch detected (breaking loop)',
JSON.stringify({
conversationID,
- lastMessageID,
batchNumber,
}),
new Set([logTypes.FARCASTER]),
);
break;
}
- lastSeenMessageID = lastMessageID;
const userFIDs = farcasterMessages.flatMap(message =>
extractFarcasterIDsFromPayload(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 6, 3:43 PM (16 h, 24 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5839310
Default Alt Text
D15459.1765035807.diff (1 KB)
Attached To
Mode
D15459: [lib] Improve message fetch stop condition
Attached
Detach File
Event Timeline
Log In to Comment