Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3246703
D5433.id17717.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
560 B
Referenced Files
None
Subscribers
None
D5433.id17717.diff
View Options
diff --git a/native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp b/native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
--- a/native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
+++ b/native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
@@ -544,6 +544,9 @@
if (!rc) {
migration_msg << "migration " << idx << " failed." << std::endl;
Logger::log(migration_msg.str());
+ if (shouldBeInTransaction) {
+ sqlite3_exec(db, "ROLLBACK;", nullptr, nullptr, nullptr);
+ }
break;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 16, 1:33 AM (21 h, 48 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2495832
Default Alt Text
D5433.id17717.diff (560 B)
Attached To
Mode
D5433: [DON'T REVIEW] `ROLLBACK` transaction on migration failure
Attached
Detach File
Event Timeline
Log In to Comment