Page MenuHomePhabricator
Files F3247090

D5697.diff
No OneTemporary
Actions

D5697.diff
View Options

diff --git a/landing/investor-profile.react.js b/landing/investor-profile.react.js
--- a/landing/investor-profile.react.js
+++ b/landing/investor-profile.react.js
@@ -33,23 +33,15 @@
linkedinHandle,
} = props;
- const profileContainerClassName = React.useMemo(
- () =>
- classNames({
- [css.profile]: true,
- [css.profileModal]: isModalActive,
- }),
- [isModalActive],
- );
+ const profileContainerClassName = classNames({
+ [css.profile]: true,
+ [css.profileModal]: isModalActive,
+ });
- const descriptionClassName = React.useMemo(
- () =>
- classNames({
- [css.description]: true,
- [css.descriptionModal]: isModalActive,
- }),
- [isModalActive],
- );
+ const descriptionClassName = classNames({
+ [css.description]: true,
+ [css.descriptionModal]: isModalActive,
+ });
const stopPropagation = React.useCallback(e => e.stopPropagation(), []);
diff --git a/web/chat/chat-thread-composer.react.js b/web/chat/chat-thread-composer.react.js
--- a/web/chat/chat-thread-composer.react.js
+++ b/web/chat/chat-thread-composer.react.js
@@ -156,13 +156,9 @@
return () => inputState.unregisterSendCallback(hideSearch);
}, [hideSearch, inputState]);
- const threadSearchContainerStyles = React.useMemo(
- () =>
- classNames(css.threadSearchContainer, {
- [css.fullHeight]: !userInfoInputArray.length,
- }),
- [userInfoInputArray.length],
- );
+ const threadSearchContainerStyles = classNames(css.threadSearchContainer, {
+ [css.fullHeight]: !userInfoInputArray.length,
+ });
return (
<div className={threadSearchContainerStyles}>
diff --git a/web/chat/chat-thread-list-item.react.js b/web/chat/chat-thread-list-item.react.js
--- a/web/chat/chat-thread-list-item.react.js
+++ b/web/chat/chat-thread-list-item.react.js
@@ -56,41 +56,25 @@
[isCreateMode, active, onClick],
);
- const containerClassName = React.useMemo(
- () =>
- classNames({
- [css.thread]: true,
- [css.activeThread]: active,
- }),
- [active],
- );
+ const containerClassName = classNames({
+ [css.thread]: true,
+ [css.activeThread]: active,
+ });
const { unread } = currentUser;
- const titleClassName = React.useMemo(
- () =>
- classNames({
- [css.title]: true,
- [css.unread]: unread,
- }),
- [unread],
- );
- const lastActivityClassName = React.useMemo(
- () =>
- classNames({
- [css.lastActivity]: true,
- [css.unread]: unread,
- [css.dark]: !unread,
- }),
- [unread],
- );
+ const titleClassName = classNames({
+ [css.title]: true,
+ [css.unread]: unread,
+ });
+ const lastActivityClassName = classNames({
+ [css.lastActivity]: true,
+ [css.unread]: unread,
+ [css.dark]: !unread,
+ });
- const breadCrumbsClassName = React.useMemo(
- () =>
- classNames(css.breadCrumbs, {
- [css.unread]: unread,
- }),
- [unread],
- );
+ const breadCrumbsClassName = classNames(css.breadCrumbs, {
+ [css.unread]: unread,
+ });
let unreadDot;
if (unread) {
diff --git a/web/chat/message-tooltip.react.js b/web/chat/message-tooltip.react.js
--- a/web/chat/message-tooltip.react.js
+++ b/web/chat/message-tooltip.react.js
@@ -93,15 +93,11 @@
const messageTooltipContainerStyle = React.useMemo(() => tooltipStyle, []);
- const containerClassNames = React.useMemo(
- () =>
- classNames(css.messageTooltipContainer, {
- [css.leftTooltipAlign]: alignment === 'left',
- [css.centerTooltipAlign]: alignment === 'center',
- [css.rightTooltipAlign]: alignment === 'right',
- }),
- [alignment],
- );
+ const containerClassNames = classNames(css.messageTooltipContainer, {
+ [css.leftTooltipAlign]: alignment === 'left',
+ [css.centerTooltipAlign]: alignment === 'center',
+ [css.rightTooltipAlign]: alignment === 'right',
+ });
return (
<div className={containerClassNames} style={messageTooltipContainerStyle}>
diff --git a/web/components/enum-settings-option-info.react.js b/web/components/enum-settings-option-info.react.js
--- a/web/components/enum-settings-option-info.react.js
+++ b/web/components/enum-settings-option-info.react.js
@@ -21,16 +21,12 @@
children,
} = props;
- const optionInfoClasses = React.useMemo(
- () =>
- classnames({
- [css.optionInfo]: true,
- [css.optionInfoInvalid]: styleStatementBasedOnValidity && !valid,
- [css.optionInfoInvalidSelected]:
- styleStatementBasedOnValidity && !valid && optionSelected,
- }),
- [styleStatementBasedOnValidity, valid, optionSelected],
- );
+ const optionInfoClasses = classnames({
+ [css.optionInfo]: true,
+ [css.optionInfoInvalid]: styleStatementBasedOnValidity && !valid,
+ [css.optionInfoInvalidSelected]:
+ styleStatementBasedOnValidity && !valid && optionSelected,
+ });
const icon = React.useMemo(() => {
if (!styleStatementBasedOnValidity) {
diff --git a/web/components/enum-settings-option.react.js b/web/components/enum-settings-option.react.js
--- a/web/components/enum-settings-option.react.js
+++ b/web/components/enum-settings-option.react.js
@@ -71,17 +71,13 @@
}
}, [disabled, type, selected]);
- const optionContainerClasses = React.useMemo(
- () =>
- classnames(css.optionContainer, {
- [css.optionContainerSelected]: selected,
- }),
- [selected],
- );
+ const optionContainerClasses = classnames(css.optionContainer, {
+ [css.optionContainerSelected]: selected,
+ });
- const optionIconClasses = React.useMemo(
- () => classnames(css.optionIcon, iconPositionClassnames[iconPosition]),
- [iconPosition],
+ const optionIconClasses = classnames(
+ css.optionIcon,
+ iconPositionClassnames[iconPosition],
);
return (
diff --git a/web/components/menu.react.js b/web/components/menu.react.js
--- a/web/components/menu.react.js
+++ b/web/components/menu.react.js
@@ -26,14 +26,10 @@
} = useRenderMenu();
const { icon, children, variant = 'thread-actions', onChange } = props;
const ourSymbol = React.useRef(Symbol());
- const menuActionListClasses = React.useMemo(
- () =>
- classnames(css.menuActionList, {
- [css.menuActionListThreadActions]: variant === 'thread-actions',
- [css.menuActionListMemberActions]: variant === 'member-actions',
- }),
- [variant],
- );
+ const menuActionListClasses = classnames(css.menuActionList, {
+ [css.menuActionListThreadActions]: variant === 'thread-actions',
+ [css.menuActionListMemberActions]: variant === 'member-actions',
+ });
const menuActionList = React.useMemo(
() => <div className={menuActionListClasses}>{children}</div>,
diff --git a/web/markdown/markdown.react.js b/web/markdown/markdown.react.js
--- a/web/markdown/markdown.react.js
+++ b/web/markdown/markdown.react.js
@@ -15,15 +15,11 @@
const { children, rules } = props;
const { simpleMarkdownRules, useDarkStyle } = rules;
- const markdownClassName = React.useMemo(
- () =>
- classNames({
- [css.markdown]: true,
- [css.darkBackground]: useDarkStyle,
- [css.lightBackground]: !useDarkStyle,
- }),
- [useDarkStyle],
- );
+ const markdownClassName = classNames({
+ [css.markdown]: true,
+ [css.darkBackground]: useDarkStyle,
+ [css.lightBackground]: !useDarkStyle,
+ });
const parser = React.useMemo(
() => SimpleMarkdown.parserFor(simpleMarkdownRules),
diff --git a/web/modals/modal.react.js b/web/modals/modal.react.js
--- a/web/modals/modal.react.js
+++ b/web/modals/modal.react.js
@@ -34,14 +34,10 @@
withCloseButton = true,
} = props;
- const modalContainerClasses = React.useMemo(
- () =>
- classNames(css.modalContainer, {
- [css.modalContainerLarge]: size === 'large',
- [css.modalContainerSmall]: size === 'small',
- }),
- [size],
- );
+ const modalContainerClasses = classNames(css.modalContainer, {
+ [css.modalContainerLarge]: size === 'large',
+ [css.modalContainerSmall]: size === 'small',
+ });
const cornerCloseButton = React.useMemo(() => {
if (!withCloseButton) {
diff --git a/web/settings/relationship/user-list.react.js b/web/settings/relationship/user-list.react.js
--- a/web/settings/relationship/user-list.react.js
+++ b/web/settings/relationship/user-list.react.js
@@ -65,13 +65,9 @@
));
}, [userRowComponent, users, onMenuVisibilityChange]);
- const containerClasses = React.useMemo(
- () =>
- classNames(css.container, {
- [css.noScroll]: isMenuVisible,
- }),
- [isMenuVisible],
- );
+ const containerClasses = classNames(css.container, {
+ [css.noScroll]: isMenuVisible,
+ });
return <div className={containerClasses}>{userRows}</div>;
}

File Metadata

Mime Type
text/plain
Expires
Sat, Nov 16, 3:28 AM (22 h, 4 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2496254
Default Alt Text
D5697.diff (8 KB)

Event Timeline