Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3260098
D6798.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D6798.diff
View Options
diff --git a/lib/shared/messages/multimedia-message-spec.js b/lib/shared/messages/multimedia-message-spec.js
--- a/lib/shared/messages/multimedia-message-spec.js
+++ b/lib/shared/messages/multimedia-message-spec.js
@@ -315,7 +315,10 @@
);
},
- generatesNotifs: async () => pushTypes.NOTIF,
+ generatesNotifs: async (
+ rawMessageInfo: RawMediaMessageInfo | RawImagesMessageInfo,
+ messageData: MediaMessageData | ImagesMessageData,
+ ) => (messageData.sidebarCreation ? undefined : pushTypes.NOTIF),
includedInRepliesCount: true,
});
diff --git a/lib/shared/messages/text-message-spec.js b/lib/shared/messages/text-message-spec.js
--- a/lib/shared/messages/text-message-spec.js
+++ b/lib/shared/messages/text-message-spec.js
@@ -202,7 +202,10 @@
}
},
- generatesNotifs: async () => pushTypes.NOTIF,
+ generatesNotifs: async (
+ rawMessageInfo: RawTextMessageInfo,
+ messageData: TextMessageData,
+ ) => (messageData.sidebarCreation ? undefined : pushTypes.NOTIF),
includedInRepliesCount: true,
});
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 16, 10:28 PM (21 h, 32 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2505941
Default Alt Text
D6798.diff (1 KB)
Attached To
Mode
D6798: [lib] Disable text/media notif when starting sidebar
Attached
Detach File
Event Timeline
Log In to Comment