Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F32632332
D7996.1767486582.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Size
4 KB
Referenced Files
None
Subscribers
None
D7996.1767486582.diff
View Options
diff --git a/web/media/multimedia-modal.react.js b/web/media/multimedia-modal.react.js
--- a/web/media/multimedia-modal.react.js
+++ b/web/media/multimedia-modal.react.js
@@ -125,12 +125,13 @@
return (
<div
className={css.multimediaModalOverlay}
- ref={this.overlayRef}
onClick={this.onBackgroundClick}
tabIndex={0}
onKeyDown={this.onKeyDown}
>
- <div className={css.mediaContainer}>{mediaModalItem}</div>
+ <div ref={this.overlayRef} className={css.mediaContainer}>
+ {mediaModalItem}
+ </div>
<XCircleIcon
onClick={this.props.popModal}
className={css.closeMultimediaModal}
diff --git a/web/modals/threads/gallery/thread-settings-media-gallery.react.js b/web/modals/threads/gallery/thread-settings-media-gallery.react.js
--- a/web/modals/threads/gallery/thread-settings-media-gallery.react.js
+++ b/web/modals/threads/gallery/thread-settings-media-gallery.react.js
@@ -83,68 +83,61 @@
[pushModal],
);
- const filteredMediaInfos = React.useMemo(() => {
+ const mediaGalleryItems = React.useMemo(() => {
+ let filteredMediaInfos = mediaInfos;
if (tab === 'Images') {
- return mediaInfos.filter(
+ filteredMediaInfos = mediaInfos.filter(
mediaInfo =>
mediaInfo.type === 'photo' || mediaInfo.type === 'encrypted_photo',
);
} else if (tab === 'Videos') {
- return mediaInfos.filter(
+ filteredMediaInfos = mediaInfos.filter(
mediaInfo =>
mediaInfo.type === 'video' || mediaInfo.type === 'encrypted_video',
);
}
- return mediaInfos;
- }, [tab, mediaInfos]);
-
- const mediaCoverPhotos = React.useMemo(
- () =>
- filteredMediaInfos.map(media => {
- if (media.type === 'photo') {
- return {
- kind: 'plain',
- uri: media.uri,
- thumbHash: media.thumbHash,
- };
- } else if (media.type === 'video') {
- return {
- kind: 'plain',
- uri: media.thumbnailURI,
- thumbHash: media.thumbnailThumbHash,
- };
- } else if (media.type === 'encrypted_photo') {
- return {
- kind: 'encrypted',
- holder: media.holder,
- encryptionKey: media.encryptionKey,
- thumbHash: media.thumbHash,
- };
- } else {
- return {
- kind: 'encrypted',
- holder: media.thumbnailHolder,
- encryptionKey: media.thumbnailEncryptionKey,
- thumbHash: media.thumbnailThumbHash,
- };
- }
- }),
- [filteredMediaInfos],
- );
- const mediaGalleryItems = React.useMemo(
- () =>
- filteredMediaInfos.map((media, i) => (
+ return filteredMediaInfos.map((media, i) => {
+ let imageSource;
+ if (media.type === 'photo') {
+ imageSource = {
+ kind: 'plain',
+ uri: media.uri,
+ thumbHash: media.thumbHash,
+ };
+ } else if (media.type === 'video') {
+ imageSource = {
+ kind: 'plain',
+ uri: media.thumbnailURI,
+ thumbHash: media.thumbnailThumbHash,
+ };
+ } else if (media.type === 'encrypted_photo') {
+ imageSource = {
+ kind: 'encrypted',
+ holder: media.holder,
+ encryptionKey: media.encryptionKey,
+ thumbHash: media.thumbHash,
+ };
+ } else {
+ imageSource = {
+ kind: 'encrypted',
+ holder: media.thumbnailHolder,
+ encryptionKey: media.thumbnailEncryptionKey,
+ thumbHash: media.thumbnailThumbHash,
+ };
+ }
+
+ return (
<GalleryItem
key={i}
onClick={() => onClick(media)}
- imageSource={mediaCoverPhotos[i]}
+ imageSource={imageSource}
imageCSSClass={css.media}
imageContainerCSSClass={css.mediaContainer}
/>
- )),
- [filteredMediaInfos, onClick, mediaCoverPhotos],
- );
+ );
+ });
+ }, [tab, mediaInfos, onClick]);
const handleScroll = React.useCallback(
async event => {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Jan 4, 12:29 AM (12 h, 22 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5891515
Default Alt Text
D7996.1767486582.diff (4 KB)
Attached To
Mode
D7996: [web] Simplify media gallery hooks
Attached
Detach File
Event Timeline
Log In to Comment