Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3297849
D4309.id13831.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D4309.id13831.diff
View Options
diff --git a/web/settings/relationship/add-users-list.css b/web/settings/relationship/add-users-list.css
--- a/web/settings/relationship/add-users-list.css
+++ b/web/settings/relationship/add-users-list.css
@@ -1,10 +1,22 @@
.container {
- overflow: auto;
height: 580px;
display: flex;
flex-direction: column;
}
+.userTagsContainer {
+ display: flex;
+ flex-wrap: wrap;
+ gap: 6px;
+}
+
+.userRowsContainer {
+ overflow: auto;
+ display: flex;
+ flex-direction: column;
+ flex: 1;
+}
+
.addUserButton {
display: flex;
flex-direction: row;
diff --git a/web/settings/relationship/add-users-list.react.js b/web/settings/relationship/add-users-list.react.js
--- a/web/settings/relationship/add-users-list.react.js
+++ b/web/settings/relationship/add-users-list.react.js
@@ -8,6 +8,7 @@
import type { GlobalAccountUserInfo } from 'lib/types/user-types.js';
import { useServerCall } from 'lib/utils/action-utils.js';
+import Label from '../../components/label.react.js';
import { useSelector } from '../../redux/redux-utils.js';
import AddUsersListItem from './add-users-list-item.react.js';
import css from './add-users-list.css';
@@ -114,11 +115,30 @@
},
[mergedUserInfos],
);
+ const deselectUser = React.useCallback(
+ (userID: string) =>
+ setPendingUsersToAdd(pendingUsers =>
+ pendingUsers.filter(userInfo => userInfo.id !== userID),
+ ),
+ [],
+ );
const pendingUserIDs = React.useMemo(
() => new Set(pendingUsersToAdd.map(userInfo => userInfo.id)),
[pendingUsersToAdd],
);
+ const userTags = React.useMemo(() => {
+ if (pendingUsersToAdd.length === 0) {
+ return null;
+ }
+ const tags = pendingUsersToAdd.map(userInfo => (
+ <Label key={userInfo.id} onClose={() => deselectUser(userInfo.id)}>
+ {userInfo.username}
+ </Label>
+ ));
+ return <div className={css.userTagsContainer}>{tags}</div>;
+ }, [deselectUser, pendingUsersToAdd]);
+
const filteredUsers = React.useMemo(
() => sortedUsers.filter(userInfo => !pendingUserIDs.has(userInfo.id)),
[pendingUserIDs, sortedUsers],
@@ -135,7 +155,12 @@
)),
[filteredUsers, selectUser],
);
- return <div className={css.container}>{userRows}</div>;
+ return (
+ <div className={css.container}>
+ {userTags}
+ <div className={css.userRowsContainer}>{userRows}</div>
+ </div>
+ );
}
export default AddUsersList;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Nov 18, 3:25 AM (21 h, 33 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2533668
Default Alt Text
D4309.id13831.diff (2 KB)
Attached To
Mode
D4309: [web] Display user tags
Attached
Detach File
Event Timeline
Log In to Comment