Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3299535
D13362.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D13362.diff
View Options
diff --git a/lib/shared/reaction-utils.js b/lib/shared/reaction-utils.js
--- a/lib/shared/reaction-utils.js
+++ b/lib/shared/reaction-utils.js
@@ -14,6 +14,7 @@
} from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from '../types/thread-permission-types.js';
+import { threadTypeIsThick } from '../types/thread-types-enum.js';
import { useSelector } from '../utils/redux-utils.js';
function useViewerAlreadySelectedMessageReactions(
@@ -92,8 +93,9 @@
}
if (
- !targetMessageInfo.id ||
- threadInfo.sourceMessageID === targetMessageInfo.id
+ (!targetMessageInfo.id && !threadTypeIsThick(threadInfo.type)) ||
+ (threadInfo.sourceMessageID &&
+ threadInfo.sourceMessageID === targetMessageInfo.id)
) {
return false;
}
diff --git a/lib/shared/sidebar-utils.js b/lib/shared/sidebar-utils.js
--- a/lib/shared/sidebar-utils.js
+++ b/lib/shared/sidebar-utils.js
@@ -210,8 +210,9 @@
}
if (
- !messageInfo.id ||
- threadInfo.sourceMessageID === messageInfo.id ||
+ (!messageInfo.id && !threadTypeIsThick(threadInfo.type)) ||
+ (threadInfo.sourceMessageID &&
+ threadInfo.sourceMessageID === messageInfo.id) ||
isInvalidSidebarSource(messageInfo)
) {
return false;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Nov 18, 1:09 PM (19 h, 29 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2534974
Default Alt Text
D13362.diff (1 KB)
Attached To
Mode
D13362: [lib] Allow reacting and creating sidebars from failed messages in thick threads
Attached
Detach File
Event Timeline
Log In to Comment