Page MenuHomePhabricator

D8799.diff
No OneTemporary

D8799.diff

diff --git a/native/chat/composed-message.react.js b/native/chat/composed-message.react.js
--- a/native/chat/composed-message.react.js
+++ b/native/chat/composed-message.react.js
@@ -215,6 +215,11 @@
// want to measure it in Message to see if it's correct
if (item.messageShapeType === 'text') {
viewStyle.push({ height: item.contentHeight });
+ } else if (item.messageShapeType === 'multimedia') {
+ const height = item.inlineEngagementHeight
+ ? item.contentHeight + item.inlineEngagementHeight
+ : item.contentHeight;
+ viewStyle.push({ height });
}
}
diff --git a/native/chat/multimedia-message.react.js b/native/chat/multimedia-message.react.js
--- a/native/chat/multimedia-message.react.js
+++ b/native/chat/multimedia-message.react.js
@@ -7,7 +7,7 @@
} from '@react-navigation/native';
import { useNavigation, useRoute } from '@react-navigation/native';
import * as React from 'react';
-import { StyleSheet, View } from 'react-native';
+import { View } from 'react-native';
import { messageKey } from 'lib/shared/message-utils.js';
import {
@@ -217,7 +217,7 @@
shouldDisplayPinIndicator={shouldDisplayPinIndicator}
{...viewProps}
>
- <View style={styles.expand} onLayout={this.onLayout} ref={this.viewRef}>
+ <View onLayout={this.onLayout} ref={this.viewRef}>
<InnerMultimediaMessage
item={item}
verticalBounds={verticalBounds}
@@ -232,12 +232,6 @@
}
}
-const styles = StyleSheet.create({
- expand: {
- flex: 1,
- },
-});
-
const ConnectedMultimediaMessage: React.ComponentType<BaseProps> =
React.memo<BaseProps>(function ConnectedMultimediaMessage(props: BaseProps) {
const navigation = useNavigation();

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 18, 2:30 PM (22 h, 7 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2535063
Default Alt Text
D8799.diff (1 KB)

Event Timeline