Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3299887
D8798.id29847.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D8798.id29847.diff
View Options
diff --git a/native/chat/composed-message.react.js b/native/chat/composed-message.react.js
--- a/native/chat/composed-message.react.js
+++ b/native/chat/composed-message.react.js
@@ -209,13 +209,22 @@
);
}
+ const viewStyle = [styles.alignment];
+ if (!__DEV__) {
+ // We don't force view height in dev mode because we
+ // want to measure it in Message to see if it's correct
+ if (item.messageShapeType === 'text') {
+ viewStyle.push({ height: item.contentHeight });
+ }
+ }
+
return (
<View {...viewProps}>
<AnimatedView style={{ opacity: contentAndHeaderOpacity }}>
<MessageHeader item={item} focused={focused} display="lowContrast" />
</AnimatedView>
<AnimatedView style={[containerStyle, editedMessageStyle]}>
- <View style={styles.alignment}>
+ <View style={viewStyle}>
<View style={[styles.content, alignStyle]}>
{deliveryIcon}
{messageBox}
diff --git a/native/chat/inner-text-message.react.js b/native/chat/inner-text-message.react.js
--- a/native/chat/inner-text-message.react.js
+++ b/native/chat/inner-text-message.react.js
@@ -95,12 +95,6 @@
const cornerStyle = getRoundedContainerStyle(filterCorners(allCorners, item));
- if (!__DEV__) {
- // We don't force view height in dev mode because we
- // want to measure it in Message to see if it's correct
- messageStyle.height = item.contentHeight;
- }
-
const rules = useTextMessageMarkdownRules(darkColor);
const textMessageMarkdown = useTextMessageMarkdown(item.messageInfo);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Nov 18, 4:21 PM (21 h, 58 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2535083
Default Alt Text
D8798.id29847.diff (1 KB)
Attached To
Mode
D8798: [native] fix forcing the incorrect height for text messages
Attached
Detach File
Event Timeline
Log In to Comment