Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F33084840
D6514.1768456516.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Size
1 KB
Referenced Files
None
Subscribers
None
D6514.1768456516.diff
View Options
diff --git a/lib/shared/messages/change-role-message-spec.js b/lib/shared/messages/change-role-message-spec.js
--- a/lib/shared/messages/change-role-message-spec.js
+++ b/lib/shared/messages/change-role-message-spec.js
@@ -15,6 +15,11 @@
import type { NotifTexts } from '../../types/notif-types';
import type { ThreadInfo } from '../../types/thread-types';
import type { RelativeUserInfo } from '../../types/user-types';
+import {
+ ET,
+ type EntityText,
+ pluralizeEntityText,
+} from '../../utils/entity-text';
import { values } from '../../utils/objects';
import {
robotextToRawString,
@@ -131,21 +136,25 @@
robotext(
messageInfo: ChangeRoleMessageInfo,
- creator: string,
+ creatorString: string,
params: RobotextParams,
- ): string {
+ ): EntityText {
const users = messageInfo.members;
invariant(users.length !== 0, 'changed whose role??');
- const usersString = params.robotextForUsers(users);
+
+ const creator = ET.user({ userInfo: messageInfo.creator });
+ const affectedUsers = pluralizeEntityText(
+ users.map(user => ET`${ET.user({ userInfo: user })}`),
+ );
const { threadInfo } = params;
invariant(threadInfo, 'ThreadInfo should be set for CHANGE_ROLE message');
const verb = threadInfo.roles[messageInfo.newRole].isDefault
? 'removed'
: 'added';
-
const noun = users.length === 1 ? 'an admin' : 'admins';
- return `${creator} ${verb} ${usersString} as ${noun}`;
+
+ return ET`${creator} ${verb} ${affectedUsers} as ${noun}`;
},
notificationTexts(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Jan 15, 5:55 AM (13 h, 26 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5936392
Default Alt Text
D6514.1768456516.diff (1 KB)
Attached To
Mode
D6514: [lib] Convert ChangeRole robotext to use EntityText
Attached
Detach File
Event Timeline
Log In to Comment