Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3378669
D4160.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D4160.diff
View Options
diff --git a/services/backup/src/Reactors/server/CreateNewBackupReactor.cpp b/services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
--- a/services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
+++ b/services/backup/src/Reactors/server/CreateNewBackupReactor.cpp
@@ -85,14 +85,13 @@
}
this->putReactor->scheduleSendingDataChunk(std::make_unique<std::string>(""));
std::unique_lock<std::mutex> lock2(this->blobPutDoneCVMutex);
- if (this->putReactor->getStatusHolder()->state == ReactorState::DONE &&
- !this->putReactor->getStatusHolder()->getStatus().ok()) {
- throw std::runtime_error(
- this->putReactor->getStatusHolder()->getStatus().error_message());
- }
if (this->putReactor->getStatusHolder()->state != ReactorState::DONE) {
this->blobPutDoneCV.wait(lock2);
- } else if (!this->putReactor->getStatusHolder()->getStatus().ok()) {
+ }
+ if (this->putReactor->getStatusHolder()->state != ReactorState::DONE) {
+ throw std::runtime_error("put reactor has not been terminated properly");
+ }
+ if (!this->putReactor->getStatusHolder()->getStatus().ok()) {
throw std::runtime_error(
this->putReactor->getStatusHolder()->getStatus().error_message());
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Nov 28, 12:21 PM (21 h, 42 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2593960
Default Alt Text
D4160.diff (1 KB)
Attached To
Mode
D4160: [services] Backup - Create new backup - Fix checking final status logic
Attached
Detach File
Event Timeline
Log In to Comment